-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adds i18n support #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds i18n support #115
Conversation
dsp-ant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to me. I won't accept it for now as we are waiting to create the draft subdirectory for docs, but otherwise good to go in my mind. We would need to do better on the actual docs tho, describing it in more depth.
Thank you for working on this!
| | Server | `resources` | Provides readable [resources]({{< ref "/specification/server/resources" >}}) | | ||
| | Server | `tools` | Exposes callable [tools]({{< ref "/specification/server/tools" >}}) | | ||
| | Server | `logging` | Emits structured [log messages]({{< ref "/specification/server/utilities/logging" >}}) | | ||
| | Server | `locale` | | Provides [i18n support]({{< ref "/specification/server/i18n" >}}) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | Server | `locale` | | Provides [i18n support]({{< ref "/specification/server/i18n" >}}) | | |
| | Server | `locale` | Provides [i18n support]({{< ref "/specification/server/i18n" >}}) | |
| {{< cards >}} | ||
| {{< card link="roots" title="Roots" icon="folder" >}} | ||
| {{< card link="sampling" title="Sampling" icon="annotation" >}} | ||
| {{< card link="i18n" title="I18n support" icon="globe-alt" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we use 'i18n' in other parts. Let's be consistent with upper/lowercase.
| {{< card link="i18n" title="I18n support" icon="globe-alt" >}} | |
| {{< card link="i18n" title="i18n support" icon="globe-alt" >}} |
| @@ -0,0 +1,11 @@ | |||
| --- | |||
| title: I18n support | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that we will start a new subdirectory for the draft of the next protocol version. We will have to move all files over. We should still mark these docs as PROPOSED
|
We've now created a separate place for the draft version of the spec, so we can move this there. Please tag us if you get a chance to tidy it up for inclusion into the draft. 🙏 |
…s-sdk Update TypeScript examples to use simplified API
|
You might consider adding directionality in addition to locale, see: |
|
Somewhat related is #469 which I like to think of as i18n in the context of an LLM native world. |
|
Closing this out since it would need to be a SEP |
Motivation and Context
Fixes #86.
Temporary PR for further discussion. Documentation very partially updated for now.
Note : "preferredLanguage", as a string, has been turned into "preferredLanguages", as an array of strings, which is a more common practice.
How Has This Been Tested?
Not so well, I fear...
Breaking Changes
None (Only new optional fields in initialization messages).
Types of changes
Checklist
Additional context