-
Notifications
You must be signed in to change notification settings - Fork 1.4k
SEP: 1034 Add default values for all primitive types in elicitation schemas #1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bhosmer-ant
merged 9 commits into
modelcontextprotocol:main
from
chughtapan:default_elicitation_values
Sep 3, 2025
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
dea8182
PR: Implement default values for all primitive types in elicitation s…
chughtapan 838b251
Merge branch 'main' into default_elicitation_values
chughtapan c468981
Address comment: supply client behaviour only one way
chughtapan 832353d
Merge branch 'main' into default_elicitation_values
chughtapan 2f9bee1
Merge branch 'main' into default_elicitation_values
chughtapan 4084967
Merge branch 'main' into default_elicitation_values
cliffhall 05ec4c3
Merge branch 'main' into default_elicitation_values
chughtapan b5ddb44
Merge branch 'main' into default_elicitation_values
cliffhall e1140ef
Merge branch 'main' into default_elicitation_values
evalstate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -233,7 +233,8 @@ The schema is restricted to these primitive types: | |
| "minLength": 3, | ||
| "maxLength": 50, | ||
| "pattern": "^[A-Za-z]+$", | ||
| "format": "email" | ||
| "format": "email", | ||
| "default": "[email protected]" | ||
| } | ||
| ``` | ||
|
|
||
|
|
@@ -247,7 +248,8 @@ The schema is restricted to these primitive types: | |
| "title": "Display Name", | ||
| "description": "Description text", | ||
| "minimum": 0, | ||
| "maximum": 100 | ||
| "maximum": 100, | ||
| "default": 50 | ||
| } | ||
| ``` | ||
|
|
||
|
|
@@ -269,7 +271,8 @@ The schema is restricted to these primitive types: | |
| "title": "Display Name", | ||
| "description": "Description text", | ||
| "enum": ["option1", "option2", "option3"], | ||
| "enumNames": ["Option 1", "Option 2", "Option 3"] | ||
| "enumNames": ["Option 1", "Option 2", "Option 3"], | ||
chughtapan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "default": "option1" | ||
| } | ||
| ``` | ||
|
|
||
|
|
@@ -279,6 +282,8 @@ Clients can use this schema to: | |
| 2. Validate user input before sending | ||
| 3. Provide better guidance to users | ||
|
|
||
| All primitive types support optional default values to provide sensible starting points. Clients that support defaults SHOULD pre-populate form fields with these values. | ||
|
|
||
| Note that complex nested structures, arrays of objects, and other advanced JSON Schema features are intentionally not supported to simplify client user experience. | ||
|
|
||
| ## Response Actions | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This goes counter to our other proposal for enums doesn't it?