Skip to content

Commit e52a16b

Browse files
cliffhallclaude
andcommitted
Merge origin/v2/main into the eslint 10 migration (#1838)
Resolves the dependency conflicts introduced by #1899 (the vitest/Storybook security untangle), which regenerated all four client lockfiles. package.json resolution is a union of both PRs' intents: - Kept from #1899: vitest / @vitest/* 4.1.10, Storybook 10.5.5 (+ @chromatic-com/storybook 5.2.1), and the deliberate `zod: "~4.3.6"` hold on clients/web (4.4.3 OOMs web's `tsc -b`, tracked as #1896). cli/tui/root keep their pre-existing `^4.3.6`, which resolves to 4.4.3 exactly as on v2/main. - Kept from this branch: eslint ^10.8.0 and @eslint/js ^10.0.1 in every client and at the root. - eslint-plugin-react-hooks resolved to ^7.1.1, intentionally DROPPING #1899's `~7.0.1` hold. That last point is the one semantic decision here. #1899 pinned eslint-plugin-react-hooks to ~7.0.1 (issue #1897) because 7.1.1 enables `react-hooks/set-state-in-effect`, which failed on 8 pre-existing violations. This PR supersedes that hold on both counts: 7.0.1's peer range stops at eslint ^9, so it ERESOLVEs against eslint 10, and this PR already fixed all 8 violations by introducing the `useValueChange` hook. Restoring the hold would break the install, and keeping it would preserve a constraint we no longer need β€” so #1897 is closed out by this branch rather than carried forward. Lockfiles were not hand-merged β€” they were reset to v2/main's regenerated versions and re-resolved with a root `npm install` (postinstall cascade). Verified with `npm run ci` from the root: validate, the per-file >=90 coverage gate, verify:build-gate, all smokes (smoke:tui included, run locally with a real TTY), and the Storybook play functions all pass. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01YAt8rqxysNbhYWLhoRm3fU
2 parents ec390af + 23e0c39 commit e52a16b

20 files changed

Lines changed: 8545 additions & 6210 deletions
Lines changed: 163 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,163 @@
1+
name: Bug report
2+
description: Report something broken in the Inspector (web, CLI, or TUI)
3+
labels: ["bug"]
4+
body:
5+
- type: markdown
6+
attributes:
7+
value: |
8+
Thanks for reporting a bug β€” **issues are how work reaches the Inspector.**
9+
10+
This repository accepts **issues, not pull requests**: design and
11+
implementation are done by the maintainers through a prompt-driven
12+
workflow ([`CONTRIBUTING.md`](https://github.com/modelcontextprotocol/inspector/blob/main/CONTRIBUTING.md)).
13+
So if you have already prototyped a fix locally, **the prompt you used
14+
plus screenshots is worth more to us than a diff** β€” there is a field
15+
for it at the bottom of this form.
16+
17+
> πŸ”’ **Do not report security vulnerabilities here.** Use the
18+
> [private advisory process](https://github.com/modelcontextprotocol/inspector/security/advisories/new)
19+
> instead β€” see [`SECURITY.md`](https://github.com/modelcontextprotocol/inspector/blob/main/SECURITY.md).
20+
21+
- type: dropdown
22+
id: version-line
23+
attributes:
24+
label: Which version line?
25+
description: >
26+
v2 is the current Inspector. v1 is deprecated and takes **security
27+
fixes only**, so a v1 bug report gets a different answer. When in
28+
doubt, it's v2.
29+
options:
30+
- v2 β€” current (`@modelcontextprotocol/inspector@latest`)
31+
- v1 β€” deprecated (`@v1-latest`, security fixes only)
32+
validations:
33+
required: true
34+
35+
- type: dropdown
36+
id: client
37+
attributes:
38+
label: Which client?
39+
description: The Inspector ships three clients from one package.
40+
options:
41+
- Web
42+
- CLI
43+
- TUI
44+
- All / shared core
45+
validations:
46+
required: true
47+
48+
- type: input
49+
id: inspector-version
50+
attributes:
51+
label: Inspector version
52+
description: The version you actually ran, not "latest".
53+
placeholder: "2.0.0"
54+
validations:
55+
required: true
56+
57+
- type: input
58+
id: node-version
59+
attributes:
60+
label: Node version
61+
description: >
62+
Output of `node --version`. The current v2 line requires Node >=
63+
22.19.0; the deprecated v1 line has its own, older floor.
64+
placeholder: "v22.19.0"
65+
validations:
66+
required: true
67+
68+
- type: input
69+
id: os
70+
attributes:
71+
label: Operating system (and browser, for the web client)
72+
placeholder: "macOS 15.5, Chrome 140"
73+
validations:
74+
required: false
75+
76+
- type: dropdown
77+
id: transport
78+
attributes:
79+
label: Transport
80+
description: How the Inspector was connected to the MCP server under inspection.
81+
options:
82+
- stdio
83+
- Streamable HTTP
84+
- SSE (legacy)
85+
- Not applicable / never connected
86+
validations:
87+
required: true
88+
89+
- type: textarea
90+
id: mcp-server
91+
attributes:
92+
label: MCP server under inspection
93+
description: >
94+
Which server, and how it is configured β€” the command or URL, the
95+
protocol era you connected with (auto / legacy / modern), and whether
96+
OAuth is involved. Redact tokens and secrets.
97+
placeholder: |
98+
Server: @modelcontextprotocol/server-everything (npx)
99+
Protocol era: modern
100+
OAuth: no
101+
validations:
102+
required: true
103+
104+
- type: textarea
105+
id: repro
106+
attributes:
107+
label: Steps to reproduce
108+
description: Numbered steps, starting from a fresh launch of the Inspector.
109+
placeholder: |
110+
1. Run `npx @modelcontextprotocol/inspector`
111+
2. Add the server above and connect
112+
3. Open the Tools tab and call `echo`
113+
validations:
114+
required: true
115+
116+
- type: textarea
117+
id: expected
118+
attributes:
119+
label: Expected behavior
120+
description: What you expected to happen.
121+
validations:
122+
required: true
123+
124+
- type: textarea
125+
id: actual
126+
attributes:
127+
label: Actual behavior
128+
description: What happened instead.
129+
validations:
130+
required: true
131+
132+
- type: textarea
133+
id: logs
134+
attributes:
135+
label: Logs, errors, or screenshots
136+
description: >
137+
Console output, the Inspector's Protocol or Network tab, or a
138+
screenshot. Redact tokens and secrets first. Screenshots can be pasted
139+
directly into this field.
140+
validations:
141+
required: false
142+
143+
- type: textarea
144+
id: prompt
145+
attributes:
146+
label: Already prototyped a fix?
147+
description: >
148+
Please don't attach a diff or open a pull request β€” share the **exact
149+
prompt(s)** you used to produce the change, plus what you verified and
150+
any before/after screenshots. We reproduce it through our own workflow
151+
so it lands with the right conventions, tests, and coverage.
152+
validations:
153+
required: false
154+
155+
- type: checkboxes
156+
id: acknowledgements
157+
attributes:
158+
label: Before you submit
159+
options:
160+
- label: I searched existing issues and this is not a duplicate.
161+
required: true
162+
- label: This is not a security vulnerability report (those go through the private advisory process).
163+
required: true
Lines changed: 88 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,88 @@
1+
name: Feature request
2+
description: Suggest an improvement to the Inspector
3+
# `v2` is safe to declare statically here: v1 takes security fixes only and
4+
# cannot receive a feature, so a feature request is v2 by construction. The bug
5+
# form can't do this β€” its version line is a reporter's answer, and `labels:`
6+
# is static.
7+
labels: ["enhancement", "v2"]
8+
body:
9+
- type: markdown
10+
attributes:
11+
value: |
12+
Thanks for suggesting an improvement.
13+
14+
**Maintainers do the implementation here** β€” this repository accepts
15+
**issues, not pull requests**
16+
([`CONTRIBUTING.md`](https://github.com/modelcontextprotocol/inspector/blob/main/CONTRIBUTING.md)).
17+
That makes a sharply-stated **problem** the most valuable thing you can
18+
give us: it is what we design against, and it survives after a specific
19+
solution turns out not to fit.
20+
21+
So please describe the problem first, and treat the solution section as
22+
one possible answer rather than the request itself.
23+
24+
> **This form targets v2.** The v1 line is deprecated and takes
25+
> **security fixes only** β€” it does not take new features.
26+
27+
- type: dropdown
28+
id: client
29+
attributes:
30+
label: Which client?
31+
options:
32+
- Web
33+
- CLI
34+
- TUI
35+
- All / shared core
36+
- Not sure
37+
validations:
38+
required: true
39+
40+
- type: textarea
41+
id: problem
42+
attributes:
43+
label: The problem
44+
description: >
45+
What are you trying to do, and what makes it hard or impossible today?
46+
Describe the situation, not the feature β€” including how often you hit
47+
it and what you do instead right now.
48+
validations:
49+
required: true
50+
51+
- type: textarea
52+
id: solution
53+
attributes:
54+
label: Solution you have in mind (optional)
55+
description: >
56+
If you have a concrete idea, describe it here. It's fine to leave this
57+
blank β€” the problem above is the part we need.
58+
validations:
59+
required: false
60+
61+
- type: textarea
62+
id: alternatives
63+
attributes:
64+
label: Alternatives or workarounds you have tried
65+
validations:
66+
required: false
67+
68+
- type: textarea
69+
id: prompt
70+
attributes:
71+
label: Already built it locally?
72+
description: >
73+
Please don't attach a diff or open a pull request β€” share the **exact
74+
prompt(s)** you used, plus screenshots of the result. We reproduce the
75+
work through our own workflow so it lands with the right conventions,
76+
tests, and coverage.
77+
validations:
78+
required: false
79+
80+
- type: checkboxes
81+
id: acknowledgements
82+
attributes:
83+
label: Before you submit
84+
options:
85+
- label: I searched existing issues and this is not a duplicate.
86+
required: true
87+
- label: This is a request for the Inspector itself, not for the MCP specification or an SDK.
88+
required: true

β€Ž.github/ISSUE_TEMPLATE/bug_report.mdβ€Ž

Lines changed: 0 additions & 73 deletions
This file was deleted.
Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
# Issue chooser configuration.
2+
#
3+
# Blank issues are disabled so every report lands in a form. The bug form
4+
# requires the facts triage needs first (client, version line, transport); the
5+
# feature form requires the client and a problem statement, and is v2-only.
6+
#
7+
# Security reports are deliberately a *contact link* rather than a template:
8+
# a template would still open a public issue, which is exactly what a
9+
# vulnerability report must not do. These links leave GitHub's issue flow and
10+
# go straight to the private advisory form. See SECURITY.md.
11+
blank_issues_enabled: false
12+
contact_links:
13+
- name: πŸ”’ Security vulnerability (v1 or v2) β€” report privately
14+
url: https://github.com/modelcontextprotocol/inspector/security/advisories/new
15+
about: >
16+
Never report a vulnerability in a public issue. Private vulnerability
17+
reporting is enabled on this repository β€” this link opens the advisory
18+
form, which is the fastest route to a maintainer. v1 is deprecated and
19+
takes security fixes only, so this is the channel for a v1 security
20+
issue.
21+
22+
- name: πŸ“œ Security policy (supported versions, what to include)
23+
url: https://github.com/modelcontextprotocol/inspector/blob/main/SECURITY.md
24+
about: >
25+
Which versions are supported, how reports are handled, and what to
26+
include in one.
27+
28+
- name: 🀝 Contribution policy β€” why there is no "New pull request"
29+
url: https://github.com/modelcontextprotocol/inspector/blob/main/CONTRIBUTING.md
30+
about: >
31+
This repository accepts issues, not pull requests β€” maintainers do the
32+
implementation. If you already built a change locally, open an issue and
33+
share the prompt you used rather than a diff.
34+
35+
- name: πŸ“– MCP documentation
36+
url: https://modelcontextprotocol.io
37+
about: >
38+
Guides and reference for the Model Context Protocol itself. Start here
39+
for "how does MCP work" questions.
40+
41+
- name: πŸ“ MCP specification β€” protocol questions and proposals
42+
url: https://github.com/modelcontextprotocol/modelcontextprotocol/issues
43+
about: >
44+
If the behavior you're reporting is defined by the protocol rather than
45+
by this tool, file it against the specification repository instead.
46+
47+
- name: 🧰 MCP TypeScript SDK
48+
url: https://github.com/modelcontextprotocol/typescript-sdk/issues
49+
about: >
50+
The Inspector is built on the TypeScript SDK. If the bug reproduces
51+
against the SDK directly (outside the Inspector), file it there.
52+
53+
- name: πŸ’¬ MCP Contributor Discord (#inspector-dev)
54+
url: https://discord.gg/6CSzBmMkjX
55+
about: >
56+
Questions, usage help, and day-to-day Inspector development discussion.
57+
Also where to say hello if you'd like to work on the Inspector with us.

0 commit comments

Comments
Β (0)