Repository navigation
Commit dac8069
fix(servers): pass-6 polish — scope absorber, thread id, drop empty OAuth, guard
Pass-6 review at #1353 (comment). Reviewer signed off as ready; landing the four marginal cleanups since they're all small.
(a) `connectPromise.catch(() => {})` moves inside the
`if (connectTimeoutMs > 0)` branch. The await-only path propagates
rejection cleanly through the outer try/catch — the absorber is
only needed when the race leaves the original promise unattended.
Code now reads as "absorber is tied to the race," which is the
real invariant.
(b) Thread `id` (POST id, PUT newId) through `buildStoredEntry` and
include it in the smuggle warning's pino bindings. Two clients
smuggling simultaneously are distinguishable in the log instead
of indistinguishable.
(c) `validateSettings` coerces empty-string OAuth fields to absent.
The form emits `""` when the user clears an input, and an empty
`oauthClientId` on disk would later be misread as "OAuth configured."
New route test pins it.
(d) `buildStoredEntry` adds a null/object guard before `"settings" in
configObj`. The route layer pre-checks this on POST and PUT, but
the helper's `unknown` parameter is a weak contract; the guard
makes it safe to call from anywhere.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>in
1 parent 02801e1 commit dac8069
3 files changed
Lines changed: 70 additions & 14 deletions
File tree
- clients/web/src/test/integration/mcp/remote
- core/mcp
- remote/node
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
605 | 605 | | |
606 | 606 | | |
607 | 607 | | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
608 | 636 | | |
609 | 637 | | |
610 | 638 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
603 | 603 | | |
604 | 604 | | |
605 | 605 | | |
606 | | - | |
607 | | - | |
608 | | - | |
609 | | - | |
610 | | - | |
611 | | - | |
612 | | - | |
613 | 606 | | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
614 | 616 | | |
615 | 617 | | |
616 | 618 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
670 | 670 | | |
671 | 671 | | |
672 | 672 | | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
673 | 677 | | |
| 678 | + | |
674 | 679 | | |
675 | 680 | | |
676 | 681 | | |
677 | | - | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
678 | 690 | | |
679 | 691 | | |
680 | | - | |
| 692 | + | |
681 | 693 | | |
682 | 694 | | |
683 | 695 | | |
| |||
755 | 767 | | |
756 | 768 | | |
757 | 769 | | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
758 | 773 | | |
759 | 774 | | |
760 | 775 | | |
761 | 776 | | |
762 | 777 | | |
763 | 778 | | |
764 | | - | |
| 779 | + | |
765 | 780 | | |
766 | 781 | | |
767 | | - | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
768 | 786 | | |
769 | 787 | | |
770 | | - | |
| 788 | + | |
771 | 789 | | |
772 | 790 | | |
773 | 791 | | |
| |||
863 | 881 | | |
864 | 882 | | |
865 | 883 | | |
866 | | - | |
| 884 | + | |
| 885 | + | |
| 886 | + | |
| 887 | + | |
| 888 | + | |
867 | 889 | | |
868 | 890 | | |
869 | 891 | | |
| |||
963 | 985 | | |
964 | 986 | | |
965 | 987 | | |
966 | | - | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
967 | 993 | | |
968 | 994 | | |
969 | 995 | | |
| |||
0 commit comments