Repository navigation
Commit aabc19f
mcpi: close CI coverage/build gaps found after typecheck fix unblocked them
The previous commit fixed verify:typecheck-coverage, which unblocked two
CI jobs that had never run to completion on this branch before: the
per-file branch-coverage gate and the externalized-dependency check.
Coverage (clients/mcpi, >=90% branches per file):
- server.ts, format-human.ts, and mcp.ts had branch coverage below the
90% gate. The gaps traced to two features added this session that had
thin or subprocess-only test coverage: sessions/show's enrichment
fields (era, serverInfo, capabilities, supportedVersions, instructions)
and the --era flag (previously untested at all).
- Added in-process tests (server.handle()/callDaemon() against a daemon
constructed directly in the test file) instead of runMcp() subprocess
calls, since subprocess code isn't visible to coverage instrumentation.
Covers sessions/show's absent-field fallback paths and full success
path, the --era auto/invalid-value paths, and the mcp.ts positional
sessionArg fallback for sessions/show.
Build gate (verify:bundle-externals):
- mcpi's tsup entry is named mcp-bin.js (multi-entry config), not
index.js like web/cli/tui, so the script's hardcoded index.js
existence check reported "build/index.js is missing" for mcpi even
after a real build. Added a per-client `entry` override (defaults to
index.js) so mcpi's real entry file is checked.
- Once buildable, the scan found @modelcontextprotocol/ext-apps (a root
runtime dependency reachable through cli's noExternal reach-in) had
been inlined into mcpi's bundle instead of staying external. cli and
tui already list it as external; added the same entry to mcpi's tsup
config.
npm run validate and npm run coverage both pass cleanly at the repo
root after these changes.
Co-authored-by: Copilot <[email protected]>1 parent 54d00b9 commit aabc19f
6 files changed
Lines changed: 75 additions & 4 deletions
File tree
- clients/mcpi
- __tests__
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
64 | 70 | | |
65 | 71 | | |
66 | 72 | | |
| |||
582 | 588 | | |
583 | 589 | | |
584 | 590 | | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
585 | 605 | | |
586 | 606 | | |
587 | 607 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
339 | 339 | | |
340 | 340 | | |
341 | 341 | | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
342 | 368 | | |
343 | 369 | | |
344 | 370 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
260 | 260 | | |
261 | 261 | | |
262 | 262 | | |
| 263 | + | |
| 264 | + | |
263 | 265 | | |
264 | 266 | | |
265 | 267 | | |
| |||
269 | 271 | | |
270 | 272 | | |
271 | 273 | | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
272 | 282 | | |
273 | 283 | | |
274 | 284 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
202 | 210 | | |
203 | 211 | | |
204 | 212 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
38 | | - | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
39 | 43 | | |
40 | 44 | | |
41 | 45 | | |
| |||
57 | 61 | | |
58 | 62 | | |
59 | 63 | | |
| 64 | + | |
60 | 65 | | |
61 | 66 | | |
62 | 67 | | |
| |||
210 | 215 | | |
211 | 216 | | |
212 | 217 | | |
213 | | - | |
| 218 | + | |
| 219 | + | |
214 | 220 | | |
215 | 221 | | |
216 | | - | |
| 222 | + | |
217 | 223 | | |
218 | 224 | | |
219 | 225 | | |
| |||
0 commit comments