You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit a58288a
Browse filesBrowse the repository at this point in the historyBrowse files
- Add a root `format` script chaining format:core + each client's format,
so the documented "npm run format" works from the root; note it in
README + AGENTS (review #1).
- Soften the cli/tui tsconfig comments: they mirror web's module/lib
*resolution* only, not its extra strictness flags — so cli/tui src is
checked slightly more loosely than web src (review #2).
- Guard schemaToForm against a non-object property value (malformed
server schema `properties: { foo: null }`) instead of throwing on
`.title`; add a test (review #3).
- Add optional `secretStore` injection to loadRunnerClientConfig and use
an InMemorySecretStore + vi.stubEnv in its tests so the result no longer
depends on the developer's real OS keychain / env (review #4, #5).
- Justify remote.test.ts's `as unknown as Response` double cast inline
per the AGENTS rule (review #5).
- Widen the core lint/format globs and the root eslint `files` to
`{ts,tsx}` so a future core/**/*.tsx can't silently escape (review #6).
- Update README's quality-gate table for validate:core + cli/tui
typecheck (review #7).
Also merges origin/v2/main into the branch.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01XNdjEPKLG637X8YmhDiEk5
- after making the changes, respond to each review comment with what was done (or why it was ignored)
210
210
211
211
### Mandatory pre-push gate
212
-
- ALWAYS do `npm run format` before committing — it auto-fixes any Prettier issues. `validate` runs `format:check` (the non-fixing variant) and will fail in CI on any unformatted file, so always run the auto-fixer first rather than letting `format:check` catch it.
212
+
- ALWAYS do `npm run format` before committing — the **root**`format`auto-fixes `core/` (`format:core`) and every client's scope in one shot. `validate` runs `format:check` (the non-fixing variant, including `format:check:core`) and will fail in CI on any unformatted file, so always run the auto-fixer first rather than letting `format:check` catch it.
213
213
-**`npm run ci` is the mandatory pre-push command** — it mirrors `.github/workflows/main.yml` (minus `npm install`): `validate` → `coverage` → `smoke` → Storybook play-function tests (installs Playwright chromium if needed). It now runs **`npm run coverage`**, the per-file ≥90 gate (lines/statements/functions/branches) that CI enforces — so `npm run ci` is a true superset of GitHub CI, and passing it locally means CI's gates will pass. Expect several minutes. **`npm run validate`** remains the fast inner-loop check during development (unit tests only — no coverage gate, no smoke, no Storybook), but it is **NOT** an acceptable substitute for `npm run ci` before pushing: `validate` runs `test`, not `test:coverage`, so it does **zero** coverage gating. Skipping the gate is how a push passes every fast local check and still fails CI (this exact gap broke PR #1601 on a function-coverage regression).
214
214
- ALWAYS do `npm run format` before committing, then **`npm run ci`** before pushing. From the repo root, `validate` runs the **`core/` gate first** (`validate:core`) and then chains the four per-client validations (`validate:web` → `validate:cli` → `validate:tui` → `validate:launcher`); each client delegates to its own `npm run validate` in its own folder (no coverage — fast). Every client is self-validating and the top level just chains them, building each client's bundle along the way (no cross-client build dependencies).
215
215
-**`validate:core` is the shared-code format + lint gate (#1689).** Each client's `prettier`/`eslint` is scoped to its own dir, so nothing reached `core/` before — `validate:core` closes that: it runs `format:check:core` (`prettier --check "core/**/*.ts"`) + `lint:core` (`eslint "core/**/*.ts"` via the **root**`eslint.config.js`). Use `npm run format:core` to auto-fix. The root carries prettier/eslint as devDependencies for this; `core/` is isomorphic (browser + Node globals, no JSX). The root `eslint.config.js` honors an `_`-prefix as the intentionally-unused marker (`argsIgnorePattern`/`varsIgnorePattern`/`caughtErrorsIgnorePattern: '^_'`).
Each client self-validates from its own folder; the root scripts chain them. There is **no** aggregate root `test` script — use `validate` (fast) or `coverage` (the gate).
|`npm run validate`|`format:check` + `lint` + `build` + fast unit tests, per client. The quick inner-loop check. |
144
-
|`npm run coverage`| The **per-file ≥90% gate** (lines/statements/functions/branches) under v8 instrumentation, per client. CI-enforced. For web this also runs the integration project.|
145
-
|`npm run smoke`| End-to-end smokes through the built launcher (`--help` dispatch + prod cli/tui/web). |
146
-
|`npm run ci`|**Mandatory pre-push command.**`validate` → `coverage` → `smoke` → Storybook. A true superset of GitHub CI. |
147
-
|`npm run pack:verify`| Publish smoke — see [Publishing](#publishing). |
148
-
149
-
Per-client scripts exist too (`validate:web`, `coverage:cli`, `smoke:tui`, …). Run `npm run format`(per client) before committing — `validate` runs the non-fixing `format:check` and fails CI on any unformatted file.
|`npm run validate`|Runs `validate:core` (the shared `core/``format:check` + `lint` gate) first, then per client: `format:check` + `lint` + **`typecheck`** (cli/tui only) + `build` + fast unit tests. The quick inner-loop check.|
144
+
|`npm run coverage`| The **per-file ≥90% gate** (lines/statements/functions/branches) under v8 instrumentation, per client. CI-enforced. For web this also runs the integration project and covers the shared `core/` runtime (including `core/json` and `core/client`). |
145
+
|`npm run smoke`| End-to-end smokes through the built launcher (`--help` dispatch + prod cli/tui/web). |
146
+
|`npm run ci`|**Mandatory pre-push command.**`validate` → `coverage` → `smoke` → Storybook. A true superset of GitHub CI. |
147
+
|`npm run pack:verify`| Publish smoke — see [Publishing](#publishing). |
148
+
149
+
Per-client scripts exist too (`validate:web`, `coverage:cli`, `smoke:tui`, …), plus root `validate:core` / `format:core` for the shared `core/` package. Run `npm run format` before committing — the root `format` fixes `core/` and every client;`validate` runs the non-fixing `format:check` and fails CI on any unformatted file.
150
150
151
151
For the full testing rules — the ≥90% per-file gate, where test files live, the unit vs. integration vs. storybook projects, and the `v8 ignore` policy — see [`AGENTS.md`](./AGENTS.md).
0 commit comments