Skip to content

Commit 750b325

Browse files
cliffhallclaude
andcommitted
ci(storybook): cache Playwright browsers + tighten AGENTS wording
Cache the Chromium binary keyed on clients/web/package-lock.json so the ~150MB download is a no-op on CI cache hits. Also clarify that CI runs test:storybook after the unit/lint/build checks (not literal `validate`, which is a local-only script). Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
1 parent 06d0697 commit 750b325

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

‎.github/workflows/main.yml‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
name: Run install, format, lint, build, and test on every push or pull request
1+
name: Run install, format, lint, build, and test on every push
22

3-
on: [push, pull_request]
3+
on: [push]
44

55
jobs:
66
build:
@@ -39,6 +39,12 @@ jobs:
3939
working-directory: ./clients/web
4040
run: npm run test:coverage
4141

42+
- name: Cache Playwright browsers
43+
uses: actions/cache@v4
44+
with:
45+
path: ~/.cache/ms-playwright
46+
key: playwright-${{ runner.os }}-${{ hashFiles('clients/web/package-lock.json') }}
47+
4248
- name: Install Playwright browsers
4349
working-directory: ./clients/web
4450
run: npx playwright install --with-deps chromium

‎AGENTS.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ All work should be driven by items on the project board.
7777

7878
### Lint-fixed, Formatted code
7979
- ALWAYS do `npm run validate` before pushing any changes, this runs the various lint, build, format checks, etc.
80-
- Also run `npm run test:storybook` before pushing — it executes every story's `play` function in headless Chromium via `@vitest/browser-playwright` (~10s). CI runs this as a separate step after `validate`; failures block merge. It is kept out of `validate` because it needs the Playwright browser binary and is much slower than the unit suite.
80+
- Also run `npm run test:storybook` before pushing — it executes every story's `play` function in headless Chromium via `@vitest/browser-playwright` (~10s). CI runs this as a separate step after the unit/lint/build checks; failures block merge. It is kept out of `validate` because it needs the Playwright browser binary and is much slower than the unit suite.
8181

8282
### Typescript instructions
8383
- Use TypeScript for all new code

0 commit comments

Comments
 (0)