Skip to content

Commit 541d2c4

Browse files
cliffhallclaude
andcommitted
review: note partialStages intentionally survives handleOpen (PR #1659)
Address the claude[bot] review's observation #2: add a comment at the handleOpen call site clarifying that partialStages is intentionally NOT cleared there — AppRenderer snapshots the fragments into its own pendingPartialsRef at build time, and the staging UI only renders while not running, so the surviving state is invisible until the next reset drains it. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01BrihGWcrM9JGRyu41nzZYw
1 parent 16fd1ea commit 541d2c4

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

‎clients/web/src/components/screens/AppsScreen/AppsScreen.tsx‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -442,6 +442,11 @@ export function AppsScreen({
442442

443443
function handleOpen() {
444444
if (!selectedTool) return;
445+
// `keepPartials` preserves the staged fragments: AppRenderer snapshots them
446+
// into its own pendingPartialsRef at bridge-build time and replays them.
447+
// The `partialStages` state is intentionally NOT cleared here — the staging
448+
// UI only renders while not running, so the surviving state is invisible
449+
// until the next select/close/back reset drains it.
445450
resetAppChannels({ keepPartials: true });
446451
setRunning(true);
447452
onOpenApp(selectedTool.name, formValues);

0 commit comments

Comments
 (0)