Skip to content

Commit 50a9634

Browse files
cliffhallclaude
andcommitted
docs: address Copilot review round 6 on #2444
Keep the advisory card's score to numbers and rubric names: the /issue-triage comment template follows each axis with free-text justification, which for an advisory is the impact and affected surface. Make the skills-index entry say public tracking is per line (v2 converts the draft; v1 files on #11) instead of a universal conversion. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Signed-off-by: cliffhall <[email protected]>
1 parent 856c82f commit 50a9634

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

‎.claude/skills/security-advisory/SKILL.md‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,15 @@ a real GitHub issue".
9191
dated. `/issue-triage` says to record it as an issue comment, and a draft
9292
card has no comments — so without this the Priority is a bare word with
9393
nothing behind it, and the step-2 re-score cannot tell what it is revising.
94-
Write the two axes, the bonuses you claimed, and the total, exactly as the
95-
comment form would; leave the provisional line in place when you re-score and
96-
add the new one under it, so the change of view is legible.
94+
Write the two axes, the bonuses you claimed, and the total as **numbers and
95+
rubric names only** — `Severity 4`, `+1 security`, `Total 6`. That is
96+
deliberately *not* the comment form: its template follows each axis with a
97+
free-text justification ("Severity 3 — a real feature is broken…"), and for
98+
an advisory that justification is the impact and the affected surface, which
99+
is exactly what the warning above keeps off the card. The reasoning behind a
100+
number belongs in the private advisory. Leave the provisional line in place
101+
when you re-score and add the new one under it, so the change of view is
102+
legible.
97103
⚠️ **Set both fields.** The board audit's non-Issue check now exempts
98104
`[GHSA-` drafts, so a half-made card no longer trips it; the audit carries a
99105
narrow replacement check (see `/issue-triage`) and it is the only thing

‎AGENTS.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ users invoke them by name.
2525
| [`pr-flow`](.claude/skills/pr-flow/SKILL.md) | Branch naming, DCO signoff, screenshots, opening the PR, requesting a Copilot review, responding, closing out | Model-invoked, or `/pr-flow` |
2626
| [`pre-push-gate`](.claude/skills/pre-push-gate/SKILL.md) | Running `npm run local:gate` and diagnosing a failing stage | Model-invoked, or `/pre-push-gate` |
2727
| [`release`](.claude/skills/release/SKILL.md) | Cutting a release: bump on `v2/main`, milestone merge, tag `origin/main`, publish | `/release` |
28-
| [`security-advisory`](.claude/skills/security-advisory/SKILL.md) | A privately reported vulnerability end to end: the draft card, who owns the code path, which release lines are affected, accepting, the private fork, publishing, converting the card | Model-invoked, or `/security-advisory` |
28+
| [`security-advisory`](.claude/skills/security-advisory/SKILL.md) | A privately reported vulnerability end to end: the draft card, who owns the code path, which release lines are affected, accepting, the private fork, publishing, public tracking per line (v2 converts; v1 files) | Model-invoked, or `/security-advisory` |
2929
| [`test-servers`](.claude/skills/test-servers/SKILL.md) | Picking and running a showcase test server; the stale-build hazard | Model-invoked, or `/test-servers` |
3030

3131
Longer-form human documentation lives in [`docs/`](./docs) — see the table in the

0 commit comments

Comments
 (0)