Skip to content

Commit 0c27159

Browse files
cliffhallclaude
andcommitted
ci: correct the playwright-package-resolution hint (sixth review)
The catch around requireFromWeb("playwright") advised `playwright install --with-deps chromium`, but that installs browser binaries, not the npm package — and the npm script already ran `playwright install` a step earlier. A failure there means the package isn't resolvable from clients/web, so the actionable fix is `npm install` at the repo root (the postinstall cascade installs clients/web's devDependencies). The chromium.launch() catch keeps its --with-deps advice (correct for the missing-system-libraries case). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01XNdjEPKLG637X8YmhDiEk5
1 parent 9c576d7 commit 0c27159

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎scripts/smoke-web-browser.mjs‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,12 @@ async function loadChromium() {
104104
try {
105105
({ chromium } = requireFromWeb("playwright"));
106106
} catch (err) {
107+
// A failure here means the playwright *npm package* isn't resolvable from
108+
// clients/web — fixed by installing devDependencies, NOT by `playwright
109+
// install` (which fetches browser binaries). `npm install` at the repo root
110+
// cascades into clients/web via postinstall.
107111
throw new Error(
108-
`could not load Playwright from clients/web — run \`npx playwright install --with-deps chromium\` (${err instanceof Error ? err.message : String(err)})`,
112+
`could not resolve the Playwright package from clients/web — run \`npm install\` at the repo root (${err instanceof Error ? err.message : String(err)})`,
109113
);
110114
}
111115
try {

0 commit comments

Comments
 (0)