all: use case-sensitive JSON unmarshaling#807
Merged
maciej-kisiel merged 2 commits intomainfrom Feb 18, 2026
Merged
Conversation
maciej-kisiel
force-pushed
the
mkisiel/json-unmarshal
branch
from
67d7a7d to
604d596
Compare
herczyn
approved these changes
Feb 18, 2026
Contributor
Author
|
@findleyr I'll leave it up go give you an opportunity for review, since you already engaged in the topic. I plan to merge it tomorrow morning (EMEA) at the latest and will likely release v1.3.1 with it as well. |
findleyr
approved these changes
Feb 18, 2026
Contributor
findleyr
left a comment
findleyr
left a comment
There was a problem hiding this comment.
Amazing! Thanks for being so on top of this.
maciej-kisiel
added a commit
that referenced
this pull request
Feb 18, 2026
As reported in #805, case insensitive unmarshaling can pose security issues. This change adjusts all non-test and non-example unmarshaling to use a case sensitive mode. This introduces a new external dependency `github.com/segmentio/encoding`.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #805, case insensitive unmarshaling can pose security issues. This change adjusts all non-test and non-example unmarshaling to use a case sensitive mode.
This introduces a new external dependency
github.com/segmentio/encoding.