oauthex: validate URL schemes in auth server metadata and DCR#712
Merged
findleyr merged 1 commit intomodelcontextprotocol:mainfrom Dec 11, 2025
Merged
oauthex: validate URL schemes in auth server metadata and DCR#712findleyr merged 1 commit intomodelcontextprotocol:mainfrom
findleyr merged 1 commit intomodelcontextprotocol:mainfrom
Conversation
markus-kusano
previously approved these changes
Dec 11, 2025
Use URL scheme validation for remaining URL fields in auth datastructures (AuthServerMeta and ClientRegistrationMetadata), to prevent XSS attacks. By comparison, the typescript SDK doesn't validate introspection_endpoint, and I don't know why. Otherwise the implementations align. Fixes modelcontextprotocol#526
markus-kusano
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use URL scheme validation for remaining URL fields in auth datastructures (AuthServerMeta and ClientRegistrationMetadata), to prevent XSS attacks.
By comparison, the typescript SDK doesn't validate introspection_endpoint, and I don't know why. Otherwise the implementations align.
Fixes #526