mcp/mcp_test: tests for elicit content validation#676
Merged
markus-kusano merged 2 commits intomodelcontextprotocol:mainfrom Dec 3, 2025
Merged
mcp/mcp_test: tests for elicit content validation#676markus-kusano merged 2 commits intomodelcontextprotocol:mainfrom
markus-kusano merged 2 commits intomodelcontextprotocol:mainfrom
Conversation
This adds a simple schema and checks that the content returned by an elicitation handler is validated against the schema. Previously, we had no test coverage checking if the content was validated (i.e., we would see no test failures if we removed content validation against the schema). The bulk of the actual validation logic is handled by the jsonschema library so adding comprehensive tests covering different schema-features is redundant, we simply need to see that some validation is happening. See modelcontextprotocol#625 for more details on the motivation of this change.
findleyr
previously approved these changes
Dec 2, 2025
Contributor
findleyr
left a comment
findleyr
left a comment
There was a problem hiding this comment.
LGTM, with one suggestion (I'll reapprove if needed).
findleyr
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a simple schema and checks that the content returned by an elicitation handler is validated against the schema. Previously, we had no test coverage checking if the content was validated (i.e., we would see no test failures if we removed content validation against the schema).
The bulk of the actual validation logic is handled by the jsonschema library so adding comprehensive tests covering different schema-features is redundant, we simply need to see that some validation is happening.
See #625 for more details on the motivation of this change.
Fixes #625