internal/oauthex: fix GetProtectedResourceMetadataFromHeader validation#561
Merged
samthanawalla merged 1 commit intomodelcontextprotocol:mainfrom Oct 8, 2025
Merged
Conversation
samthanawalla
suggested changes
Oct 7, 2025
Contributor
samthanawalla
left a comment
samthanawalla
left a comment
There was a problem hiding this comment.
Thank you! It LGTM once the conflicts are resolved
oauthex/resource_meta.go
Outdated
| @@ -167,7 +168,7 @@ func getPRM(ctx context.Context, purl string, c *http.Client, wantResource strin | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| // Validate the Resource field to thwart impersonation attacks (section 3.3). | |||
| // Validate the Resource field (see RFC 9728, section 3.3) as well as issue #560 | |||
Contributor
There was a problem hiding this comment.
remove reference to issue #560 and end with a period
GetProtectedResourceMetadataFromHeader was validating the resource field against the metadata endpoint URL instead of the original server URL. Per RFC 9728 section 3.3, the resource field must match the URL that the client used to make the request to the resource server. Fixes: modelcontextprotocol#560 This fix adds a serverURL parameter and validates against the correct value.
samthanawalla
approved these changes
Oct 7, 2025
Contributor
|
@samthanawalla are these good to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetProtectedResourceMetadataFromHeader was validating the resource field against the metadata endpoint URL instead of the original server URL. Per RFC 9728 section 3.3, the resource field must match the URL that the client used to make the request to the resource server.
Fixes: #560