mcp: treat pointers equivalently to non-pointers when deriving schema#338
Merged
findleyr merged 2 commits intomodelcontextprotocol:mainfrom Aug 21, 2025
Merged
mcp: treat pointers equivalently to non-pointers when deriving schema#338findleyr merged 2 commits intomodelcontextprotocol:mainfrom
findleyr merged 2 commits intomodelcontextprotocol:mainfrom
Conversation
Contributor
|
This is thorough. But it won't merge at all after #325. I gutted newServerTool. |
As reported in modelcontextprotocol#199 and modelcontextprotocol#200, the fact that we return a possibly "null" schema for pointer types breaks various clients, which expect schemas to be of type "object". This is an unfortunate footgun. For now, assume that the user wants us to treat pointers equivalently to non-pointers. If we want to change this behavior in the future, we can do so behind an option. + a test Also fix the handling of nil results in the case where the output schema is non-nil: we must provide structured content in this case. (This was causing the test to fail). Fixes modelcontextprotocol#199 Fixes modelcontextprotocol#200
jba
requested changes
Aug 21, 2025
jba
reviewed
Aug 21, 2025
jba
approved these changes
Aug 21, 2025
findleyr
added a commit
to findleyr/go-sdk
that referenced
this pull request
Aug 21, 2025
Some bad merging in modelcontextprotocol#338 led to a bad bug in the handling of structured output for pointer output types. Add a conformance test and fix the bug.
samthanawalla
pushed a commit
that referenced
this pull request
Aug 21, 2025
Some bad merging in #338 led to a bad bug in the handling of structured output for pointer output types. Add a conformance test and fix the bug.
yasomaru
pushed a commit
to yasomaru/go-sdk
that referenced
this pull request
Aug 28, 2025
Some bad merging in modelcontextprotocol#338 led to a bad bug in the handling of structured output for pointer output types. Add a conformance test and fix the bug.
RatStar811
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #199 and #200, the fact that we return a possibly "null" schema for pointer types breaks various clients, which expect schemas to be of type "object". This is an unfortunate footgun. For now, assume that the user wants us to treat pointers equivalently to non-pointers. If we want to change this behavior in the future, we can do so behind an option.
Also fix the handling of nil results in the case where the output schema is non-nil: we must provide structured content in this case. (This was causing the test to fail).
Fixes #199
Fixes #200