Repository navigation
fix(mcp): use %v and ID.Raw() for jsonrpc response summary - #1382
Merged
guglielmo-san merged 3 commits intoOct 12, 2026
Merged
guglielmo-san merged 3 commits into
guglielmo-san merged 3 commits into
Conversation
… a struct)
requestSummary formatted `msg.ID` (a jsonrpc.ID struct, no Stringer/Formatter)
with %d, producing garbage like `{%!d(string=req-1)}` or `{5}` in the
user-facing errors that interpolate requestSummary. Use %v on msg.ID.Raw(), the
same idiom already used elsewhere in this file.
guglielmo-san
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requestSummaryformattedmsg.IDwith%d:msg.IDis ajsonrpc.IDstruct (noString()/Formatter), so%dyields garbage —{%!d(string=req-1)}for a string ID,{5}(stray braces) for an int ID — which then shows up in the user-facing errors that interpolaterequestSummary(fmt.Errorf("%s: %v", requestSummary, err)). Use%vonmsg.ID.Raw(), the idiom already used elsewhere in this file (reqID.Raw()).go build ./...,go vet ./mcp/pass.