Remove s_additionalProperties from McpClientTool #1080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…McpClientTool Co-authored-by: stephentoub <[email protected]>
Copilot
AI
changed the title
[WIP] Remove s_additionalProperties and related references
Remove s_additionalProperties from McpClientTool
Dec 9, 2025
stephentoub
approved these changes
Dec 9, 2025
Member
|
Ah! Now it all makes sense with the bug I encountered with the beta anthropic client. I assume this was introduced because of another API where this default is preferable with strict mode? |
PederHP
approved these changes
Dec 9, 2025
eiriktsarpalis
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
McpClientToolwas unconditionally settingStrict = falseinAdditionalPropertiesfor all tools, which shouldn't be a blanket default.Changes
s_additionalPropertiesstatic field andAdditionalPropertiesoverrideSystem.Collections.ObjectModelimportThe class now inherits the default
AdditionalPropertiesbehavior fromAIFunction.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.