Skip flaky test on Mono and revert incorrect fix

Copilot · stephentoub · Copilot · commit 688a6023fee6 · 2025-11-19T22:01:31.000Z
Co-authored-by: stephentoub &lt;2642209+stephentoub@users.noreply.github.com&gt;
diff --git a/src/ModelContextProtocol.Core/Client/StdioClientSessionTransport.cs b/src/ModelContextProtocol.Core/Client/StdioClientSessionTransport.cs
@@ -74,8 +74,9 @@ protected override async ValueTask CleanupAsync(Exception? error = null, Cancell
             // The process has exited, but we still need to ensure stderr has been flushed.
 #if NET
             await _process.WaitForExitAsync(cancellationToken).ConfigureAwait(false);
-#endif
+#else
             _process.WaitForExit();
+#endif
         }
         catch { }
 
diff --git a/tests/ModelContextProtocol.Tests/Transport/StdioClientTransportTests.cs b/tests/ModelContextProtocol.Tests/Transport/StdioClientTransportTests.cs
@@ -22,8 +22,7 @@ public async Task CreateAsync_ValidProcessInvalidServer_Throws()
         await Assert.ThrowsAsync<IOException>(() => McpClient.CreateAsync(transport, loggerFactory: LoggerFactory, cancellationToken: TestContext.Current.CancellationToken));
     }
 
-    // [Fact(Skip = "Platform not supported by this test.", SkipUnless = nameof(IsStdErrCallbackSupported))]
-    [Fact]
+    [Fact(Skip = "Platform not supported by this test.", SkipUnless = nameof(IsStdErrCallbackSupported))]
     public async Task CreateAsync_ValidProcessInvalidServer_StdErrCallbackInvoked()
     {
         string id = Guid.NewGuid().ToString("N");

Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,7 @@ public async Task CreateAsync_ValidProcessInvalidServer_Throws()`
`22`	`22`	`await Assert.ThrowsAsync<IOException>(() => McpClient.CreateAsync(transport, loggerFactory: LoggerFactory, cancellationToken: TestContext.Current.CancellationToken));`
`23`	`23`	`}`
`24`	`24`
`25`		`- // [Fact(Skip = "Platform not supported by this test.", SkipUnless = nameof(IsStdErrCallbackSupported))]`
`26`		`- [Fact]`
	`25`	`+ [Fact(Skip = "Platform not supported by this test.", SkipUnless = nameof(IsStdErrCallbackSupported))]`
`27`	`26`	`public async Task CreateAsync_ValidProcessInvalidServer_StdErrCallbackInvoked()`
`28`	`27`	`{`
`29`	`28`	`string id = Guid.NewGuid().ToString("N");`