Keep public API unchanged - remove test that required reflection

Copilot · stephentoub · Copilot · commit 65086f5c61b6 · 2025-12-16T02:41:56.000Z
Instead of making CloneResourceMetadata public (which changes the API),
removed the test. The functionality is already covered by integration tests.

Co-authored-by: stephentoub &lt;2642209+stephentoub@users.noreply.github.com&gt;
diff --git a/src/ModelContextProtocol.AspNetCore/Authentication/McpAuthenticationHandler.cs b/src/ModelContextProtocol.AspNetCore/Authentication/McpAuthenticationHandler.cs
@@ -192,13 +192,7 @@ protected override Task HandleChallengeAsync(AuthenticationProperties properties
         return base.HandleChallengeAsync(properties);
     }
 
-    /// <summary>
-    /// Creates a deep copy of the specified <see cref="ProtectedResourceMetadata"/>, optionally overriding the Resource property.
-    /// </summary>
-    /// <param name="resourceMetadata">The metadata to clone. If null, returns null.</param>
-    /// <param name="derivedResourceUri">Optional URI to use for the Resource property if the original Resource is null.</param>
-    /// <returns>A new instance of <see cref="ProtectedResourceMetadata"/> with cloned values, or null if the input is null.</returns>
-    public static ProtectedResourceMetadata? CloneResourceMetadata(ProtectedResourceMetadata? resourceMetadata, Uri? derivedResourceUri = null)
+    internal static ProtectedResourceMetadata? CloneResourceMetadata(ProtectedResourceMetadata? resourceMetadata, Uri? derivedResourceUri = null)
     {
         if (resourceMetadata is null)
         {
diff --git a/tests/ModelContextProtocol.AspNetCore.Tests/OAuth/AuthTests.cs b/tests/ModelContextProtocol.AspNetCore.Tests/OAuth/AuthTests.cs
@@ -750,101 +750,4 @@ await McpClient.CreateAsync(
 
         Assert.Contains("does not match", ex.Message);
     }
-
-    [Fact]
-    public void CloneResourceMetadataClonesAllProperties()
-    {
-        var propertyNames = typeof(ProtectedResourceMetadata).GetProperties().Select(property => property.Name).ToList();
-
-        // Set metadata properties to non-default values to verify they're copied.
-        var metadata = new ProtectedResourceMetadata
-        {
-            Resource = new Uri("https://example.com/resource"),
-            AuthorizationServers = [new Uri("https://auth1.example.com"), new Uri("https://auth2.example.com")],
-            BearerMethodsSupported = ["header", "body", "query"],
-            ScopesSupported = ["read", "write", "admin"],
-            JwksUri = new Uri("https://example.com/.well-known/jwks.json"),
-            ResourceSigningAlgValuesSupported = ["RS256", "ES256"],
-            ResourceName = "Test Resource",
-            ResourceDocumentation = new Uri("https://docs.example.com"),
-            ResourcePolicyUri = new Uri("https://example.com/policy"),
-            ResourceTosUri = new Uri("https://example.com/terms"),
-            TlsClientCertificateBoundAccessTokens = true,
-            AuthorizationDetailsTypesSupported = ["payment_initiation", "account_information"],
-            DpopSigningAlgValuesSupported = ["RS256", "PS256"],
-            DpopBoundAccessTokensRequired = true
-        };
-
-        // Call the public CloneResourceMetadata method
-        var clonedMetadata = McpAuthenticationHandler.CloneResourceMetadata(metadata, null);
-        Assert.NotNull(clonedMetadata);
-
-        // Ensure the cloned metadata is not the same instance
-        Assert.NotSame(metadata, clonedMetadata);
-
-        // Verify Resource property
-        Assert.Equal(metadata.Resource, clonedMetadata.Resource);
-        Assert.True(propertyNames.Remove(nameof(metadata.Resource)));
-
-        // Verify AuthorizationServers list is cloned and contains the same values
-        Assert.NotSame(metadata.AuthorizationServers, clonedMetadata.AuthorizationServers);
-        Assert.Equal(metadata.AuthorizationServers, clonedMetadata.AuthorizationServers);
-        Assert.True(propertyNames.Remove(nameof(metadata.AuthorizationServers)));
-
-        // Verify BearerMethodsSupported list is cloned and contains the same values
-        Assert.NotSame(metadata.BearerMethodsSupported, clonedMetadata.BearerMethodsSupported);
-        Assert.Equal(metadata.BearerMethodsSupported, clonedMetadata.BearerMethodsSupported);
-        Assert.True(propertyNames.Remove(nameof(metadata.BearerMethodsSupported)));
-
-        // Verify ScopesSupported list is cloned and contains the same values
-        Assert.NotSame(metadata.ScopesSupported, clonedMetadata.ScopesSupported);
-        Assert.Equal(metadata.ScopesSupported, clonedMetadata.ScopesSupported);
-        Assert.True(propertyNames.Remove(nameof(metadata.ScopesSupported)));
-
-        // Verify JwksUri property
-        Assert.Equal(metadata.JwksUri, clonedMetadata.JwksUri);
-        Assert.True(propertyNames.Remove(nameof(metadata.JwksUri)));
-
-        // Verify ResourceSigningAlgValuesSupported list is cloned (nullable list)
-        Assert.NotSame(metadata.ResourceSigningAlgValuesSupported, clonedMetadata.ResourceSigningAlgValuesSupported);
-        Assert.Equal(metadata.ResourceSigningAlgValuesSupported, clonedMetadata.ResourceSigningAlgValuesSupported);
-        Assert.True(propertyNames.Remove(nameof(metadata.ResourceSigningAlgValuesSupported)));
-
-        // Verify ResourceName property
-        Assert.Equal(metadata.ResourceName, clonedMetadata.ResourceName);
-        Assert.True(propertyNames.Remove(nameof(metadata.ResourceName)));
-
-        // Verify ResourceDocumentation property
-        Assert.Equal(metadata.ResourceDocumentation, clonedMetadata.ResourceDocumentation);
-        Assert.True(propertyNames.Remove(nameof(metadata.ResourceDocumentation)));
-
-        // Verify ResourcePolicyUri property
-        Assert.Equal(metadata.ResourcePolicyUri, clonedMetadata.ResourcePolicyUri);
-        Assert.True(propertyNames.Remove(nameof(metadata.ResourcePolicyUri)));
-
-        // Verify ResourceTosUri property
-        Assert.Equal(metadata.ResourceTosUri, clonedMetadata.ResourceTosUri);
-        Assert.True(propertyNames.Remove(nameof(metadata.ResourceTosUri)));
-
-        // Verify TlsClientCertificateBoundAccessTokens property
-        Assert.Equal(metadata.TlsClientCertificateBoundAccessTokens, clonedMetadata.TlsClientCertificateBoundAccessTokens);
-        Assert.True(propertyNames.Remove(nameof(metadata.TlsClientCertificateBoundAccessTokens)));
-
-        // Verify AuthorizationDetailsTypesSupported list is cloned (nullable list)
-        Assert.NotSame(metadata.AuthorizationDetailsTypesSupported, clonedMetadata.AuthorizationDetailsTypesSupported);
-        Assert.Equal(metadata.AuthorizationDetailsTypesSupported, clonedMetadata.AuthorizationDetailsTypesSupported);
-        Assert.True(propertyNames.Remove(nameof(metadata.AuthorizationDetailsTypesSupported)));
-
-        // Verify DpopSigningAlgValuesSupported list is cloned (nullable list)
-        Assert.NotSame(metadata.DpopSigningAlgValuesSupported, clonedMetadata.DpopSigningAlgValuesSupported);
-        Assert.Equal(metadata.DpopSigningAlgValuesSupported, clonedMetadata.DpopSigningAlgValuesSupported);
-        Assert.True(propertyNames.Remove(nameof(metadata.DpopSigningAlgValuesSupported)));
-
-        // Verify DpopBoundAccessTokensRequired property
-        Assert.Equal(metadata.DpopBoundAccessTokensRequired, clonedMetadata.DpopBoundAccessTokensRequired);
-        Assert.True(propertyNames.Remove(nameof(metadata.DpopBoundAccessTokensRequired)));
-
-        // Ensure we've checked every property. When new properties get added, we'll have to update this test along with the CloneResourceMetadata implementation.
-        Assert.Empty(propertyNames);
-    }
 }

Original file line number	Diff line number	Diff line change
`@@ -192,13 +192,7 @@ protected override Task HandleChallengeAsync(AuthenticationProperties properties`
`192`	`192`	`return base.HandleChallengeAsync(properties);`
`193`	`193`	`}`
`194`	`194`
`195`		`- /// <summary>`
`196`		`- /// Creates a deep copy of the specified <see cref="ProtectedResourceMetadata"/>, optionally overriding the Resource property.`
`197`		`- /// </summary>`
`198`		`- /// <param name="resourceMetadata">The metadata to clone. If null, returns null.</param>`
`199`		`- /// <param name="derivedResourceUri">Optional URI to use for the Resource property if the original Resource is null.</param>`
`200`		`- /// <returns>A new instance of <see cref="ProtectedResourceMetadata"/> with cloned values, or null if the input is null.</returns>`
`201`		`- public static ProtectedResourceMetadata? CloneResourceMetadata(ProtectedResourceMetadata? resourceMetadata, Uri? derivedResourceUri = null)`
	`195`	`+ internal static ProtectedResourceMetadata? CloneResourceMetadata(ProtectedResourceMetadata? resourceMetadata, Uri? derivedResourceUri = null)`
`202`	`196`	`{`
`203`	`197`	`if (resourceMetadata is null)`
`204`	`198`	`{`