Start the verification of slice::Iter
#148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
force-pushed
the
verify-iter
branch
2 times, most recently
from
3539fa1 to
f9d1c17
Compare
zhassan-aws
reviewed
Nov 5, 2024
zhassan-aws
approved these changes
Nov 7, 2024
There are a few harnesses failing that needs further debugging. I commented them out for now.
- Improve first / last logic - Add comment to invariant - Fix IterMut invariant
Author
|
trigger approval checks after rebase from main. Sorry, I accidentally rebased instead of merging. |
celinval
commented
Nov 7, 2024
Author
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
Oops. I forgot it has to be a review comment
celinval
added a commit
that referenced
this pull request
Dec 6, 2024
In #148 and #122, we had to comment out a few harnesses due to the issue model-checking/kani#3670. But now that the fix has been pushed, we can enable them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the invariant for
IterandIterMutand contains harnesses for someItermethods. I commented out a bunch of harnesses that are currently failing until I can debug them further.I am planning to add harnesses for
IterMutlater, but I could use some early feedback. Thanks!By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.