Fix rmc --gen-c #673
Merged
Fix rmc --gen-c #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
force-pushed
the
main
branch
3 times, most recently
from
bf726c0 to
53a4d9f
Compare
avanhatt
approved these changes
Dec 2, 2021
Contributor
avanhatt
left a comment
avanhatt
left a comment
There was a problem hiding this comment.
Thanks for catching this!!
danielsn
approved these changes
Dec 7, 2021
tedinski
approved these changes
Dec 7, 2021
There was a regression introduced by 7820fa5 that broke rmc --gen-c. This change fixes that. I am also fixing a random white space from my previous commit.
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
There was a regression introduced by b6e2bcad6cb that broke rmc --gen-c. This change fixes that. I am also fixing a random white space from my previous commit.
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
There was a regression introduced by b6e2bcad6cb that broke rmc --gen-c. This change fixes that. I am also fixing a random white space from my previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression introduced by 7820fa5 that broke rmc --gen-c. This change fixes that. I am also fixing a random white space from my previous commit.
Resolved issues:
None
Call-outs:
Testing:
How is this change tested? We don't have any regression test for --gen-c yet.
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.