Added new APIs to the RMC crate for creating non-deterministic slices #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
suggested changes
Nov 23, 2021
Contributor
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
Should we rename these functions to any_* to follow the same new name of nondet that we discussed offline?
Contributor
Author
I prefer if we rename all of them at the same time once we settle on the new name. |
adpaco-aws
reviewed
Nov 29, 2021
celinval
approved these changes
Dec 1, 2021
Contributor
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
Just a few minor comments.
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
…model-checking#663) Added new APIs to the RMC crate for creating non-deterministic slices
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
…#663) Added new APIs to the RMC crate for creating non-deterministic slices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added several convenience APIs to the RMC crate for creating non-deterministic slices.
Resolved issues:
Resolves #614
Call-outs:
Testing:
How is this change tested? Added two new tests
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.