Break min/max_int into their own util functions, and have them return BigInt to avoid any arbitrary width constraints #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhassan-aws
reviewed
Oct 29, 2021
… BigInt to avoid any arbitrary width constraints
zhassan-aws
approved these changes
Nov 1, 2021
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
… BigInt to avoid any arbitrary width constraints (model-checking#605)
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
… BigInt to avoid any arbitrary width constraints (#605)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently,
min_intandmax_intwork on 128 bit representations, which means we can't calculate them for larger sizes. This was causing unnecessary codegen failures. Instead, use BigInt so we have no width constraints (until Rust runs out of memory, anyway)Resolved issues:
Resolves #414
Call-outs:
Testing:
How is this change tested? Additional unit tests
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.