Fix for computing the minimum offset for an enum variant #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avanhatt
reviewed
Sep 2, 2021
danielsn
reviewed
Sep 3, 2021
Contributor
danielsn
left a comment
danielsn
left a comment
There was a problem hiding this comment.
LGTM, aside from one comment.
danielsn
reviewed
Sep 3, 2021
compiler/rustc_codegen_llvm/src/gotoc/mir_to_goto/codegen/typ.rs
Outdated
Show resolved
Hide resolved
…nto min-offset-fix Merging changes from main
danielsn
approved these changes
Sep 3, 2021
chinmaydd
pushed a commit
to chinmaydd/rmc
that referenced
this pull request
Sep 4, 2021
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assertion failed: current_offset <= next_offsetin buildingregex#412Description of changes:
RMC panics for certain structs within enums. This PR fixes this issue.
Resolved issues:
Resolves #111 and partially #412.
Call-outs:
Testing:
Tested on issues #111 and #412. PR also includes a new test.
No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.