Refactor backend code into its own file #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avanhatt
reviewed
Aug 12, 2021
| use rustc_middle::ty::{self, Instance, TyS}; | ||
| use tracing::{debug, warn}; | ||
|
|
||
| /// Utility to skip functions that can't currently be successfully codgenned. |
Contributor
There was a problem hiding this comment.
I think I agree with Ted that this makes more sense close to where it's used: whether we skip a function is a property of codegening the crate, not the function itself?
Contributor
Author
There was a problem hiding this comment.
Its actually used in function.rs. But I agree that that's maybe not where you would expect to find it.
tedinski
approved these changes
Aug 12, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 17, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 24, 2021
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
mod.rs was a mess. This moves the remaining code into properly named files.
Resolved issues:
Resolves #ISSUE-NUMBER
Call-outs:
Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.