Fix vtable size check for never #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsn
reviewed
Aug 12, 2021
| let check = Expr::eq(Expr::object_size(temp_var.address_of()), vt_size.clone()); | ||
| let assert_msg = format!("Correct CBMC vtable size for {:?}", operand_type.kind()); | ||
| let cbmc_size = if ty.clone().is_empty() { | ||
| // CBMC errors on passing a pointer to void to __CPROVER_OBJECT_SIZE, so just pass 0 |
Contributor
There was a problem hiding this comment.
Are we guaranteed this is correct? Or is this a temporary hack?
Contributor
Author
There was a problem hiding this comment.
Added an assert for the Never case and a link showing that we do know the size is 0. This way, will get a more detailed error if this fails again for a different type.
danielsn
approved these changes
Aug 12, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 17, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 24, 2021
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
With some combinations of traits and the Never type, the CBMC-time sanity check assert fails because you cannot take an object size of void.
Breaking this into its own PR to land since it's coming up outside of drop work.
Resolved issues:
Resolves #421
Call-outs:
Working on getting a small example now, but a little difficulty since this happens in external crate code.
Testing:
Existing tests, working on minimal example.
No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.