Support trait_upcasting
#4001
Merged
Support trait_upcasting
#4001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clubby789
force-pushed
the
dyn-upcasting
branch
3 times, most recently
from
4944c63 to
79de96a
Compare
zhassan-aws
reviewed
Apr 17, 2025
Contributor
zhassan-aws
left a comment
zhassan-aws
left a comment
There was a problem hiding this comment.
Awesome, thanks for your contribution! Can you add a reference to the upstream implementation in the code? Otherwise, this is good to go.
clubby789
force-pushed
the
dyn-upcasting
branch
from
79de96a to
a6d3358
Compare
zhassan-aws
approved these changes
Apr 23, 2025
Merged
via the queue into
model-checking:main
with commit Apr 23, 2025
0aa6c41
26 of 28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the recently stabilized
trait_upcastingfeature. Currently, when we cast between non-matching dyn traits, codegen incorrectly reuses the old vtable, leading to confusing issues (#3998).This reproduces the upcasting logic from upstream rustc to load the vptr when performing the coercion.
Resolves #358
Resolves #3998
This was tested using the motivating example from the linked issue. I will add further tests to make sure this feature is robust.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.