Remove support for the unstable argument --function
#3278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a legacy argument that we have very limited support to. We kept it around for bookrunner tests, which has been removed already. This simplifies our code quite a bit.
celinval
force-pushed
the
issue-xxxx-fn-opt
branch
from
6aa8f7a to
46e80dd
Compare
adpaco-aws
reviewed
Jun 21, 2024
adpaco-aws
approved these changes
Jun 21, 2024
Contributor
adpaco-aws
left a comment
adpaco-aws
left a comment
There was a problem hiding this comment.
Thanks, @celinval !
Do we want to mention this as a breaking change in the changelog? I doubt anyone depends on it so maybe listing the PR as usual is just enough.
Contributor
Author
Good question. This was an unstable feature that we provided very limited support, so I am not sure where to add it. That said, Maybe adding a callout might still be a good idea. |
celinval
changed the title
--function from Kani--function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a legacy argument that we have very limited support to. We kept it around for bookrunner tests, which has been removed already.
Resolves #2129
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.