Skip to content

Conversation

@adpaco-aws
Copy link
Contributor

This PR modifies the pattern used to exclude files from the copyright check for expected files. This ensures we check the copyright in files under tests/expected/ while it skips the check for expected and *.expected files. It also adds/modifies copyright headers for some files that weren't being checked until now.

Resolves #3141

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws requested a review from a team as a code owner May 3, 2024 17:51
Copy link
Contributor

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adpaco-aws adpaco-aws merged commit 36f715c into model-checking:main May 3, 2024
karkhaz added a commit that referenced this pull request May 7, 2024
For reference, here is the auto-generated changelog

## What's Changed
* Upgrade toolchain to 2024-04-18 and improve toolchain workflow by
@celinval in #3149
* Automatic toolchain upgrade to nightly-2024-04-19 by @github-actions
in #3150
* Stabilize cover statement and update contracts RFC by @celinval in
#3091
* Automatic toolchain upgrade to nightly-2024-04-20 by @github-actions
in #3154
* Bump tests/perf/s2n-quic from `2d5e891` to `5f88e54` by @dependabot in
#3140
* Automatic cargo update to 2024-04-22 by @github-actions in
#3157
* Automatic toolchain upgrade to nightly-2024-04-21 by @github-actions
in #3158
* Bump tests/perf/s2n-quic from `5f88e54` to `9730578` by @dependabot in
#3159
* Fix cargo audit error by @jaisnan in
#3160
* Fix cbmc-update CI job by @tautschnig in
#3156
* Automatic cargo update to 2024-04-29 by @github-actions in
#3165
* Bump tests/perf/s2n-quic from `9730578` to `1436af7` by @dependabot in
#3166
* Do not assume that ZST-typed symbols refer to unique objects by
@tautschnig in #3134
* Fix copyright check for `expected` tests by @adpaco-aws in
#3170
* Remove kani::Arbitrary from the modifies contract instrumentation by
@feliperodri in #3169
* Automatic cargo update to 2024-05-06 by @github-actions in
#3172
* Bump tests/perf/s2n-quic from `1436af7` to `6dd41e0` by @dependabot in
#3174
* Avoid unnecessary uses of Location::none() by @tautschnig in
#3173


**Full Changelog**:
kani-0.50.0...kani-0.51.0

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.

---------

Co-authored-by: Adrian Palacios <[email protected]>
zpzigi754 pushed a commit to zpzigi754/kani that referenced this pull request May 8, 2024
This PR modifies the pattern used to exclude files from the copyright
check for `expected` files. This ensures we check the copyright in files
under `tests/expected/` while it skips the check for `expected` and
`*.expected` files. It also adds/modifies copyright headers for some
files that weren't being checked until now.

Resolves model-checking#3141
qinheping pushed a commit to qinheping/kani that referenced this pull request May 9, 2024
This PR modifies the pattern used to exclude files from the copyright
check for `expected` files. This ensures we check the copyright in files
under `tests/expected/` while it skips the check for `expected` and
`*.expected` files. It also adds/modifies copyright headers for some
files that weren't being checked until now.

Resolves model-checking#3141
qinheping pushed a commit to qinheping/kani that referenced this pull request May 9, 2024
For reference, here is the auto-generated changelog

## What's Changed
* Upgrade toolchain to 2024-04-18 and improve toolchain workflow by
@celinval in model-checking#3149
* Automatic toolchain upgrade to nightly-2024-04-19 by @github-actions
in model-checking#3150
* Stabilize cover statement and update contracts RFC by @celinval in
model-checking#3091
* Automatic toolchain upgrade to nightly-2024-04-20 by @github-actions
in model-checking#3154
* Bump tests/perf/s2n-quic from `2d5e891` to `5f88e54` by @dependabot in
model-checking#3140
* Automatic cargo update to 2024-04-22 by @github-actions in
model-checking#3157
* Automatic toolchain upgrade to nightly-2024-04-21 by @github-actions
in model-checking#3158
* Bump tests/perf/s2n-quic from `5f88e54` to `9730578` by @dependabot in
model-checking#3159
* Fix cargo audit error by @jaisnan in
model-checking#3160
* Fix cbmc-update CI job by @tautschnig in
model-checking#3156
* Automatic cargo update to 2024-04-29 by @github-actions in
model-checking#3165
* Bump tests/perf/s2n-quic from `9730578` to `1436af7` by @dependabot in
model-checking#3166
* Do not assume that ZST-typed symbols refer to unique objects by
@tautschnig in model-checking#3134
* Fix copyright check for `expected` tests by @adpaco-aws in
model-checking#3170
* Remove kani::Arbitrary from the modifies contract instrumentation by
@feliperodri in model-checking#3169
* Automatic cargo update to 2024-05-06 by @github-actions in
model-checking#3172
* Bump tests/perf/s2n-quic from `1436af7` to `6dd41e0` by @dependabot in
model-checking#3174
* Avoid unnecessary uses of Location::none() by @tautschnig in
model-checking#3173


**Full Changelog**:
model-checking/kani@kani-0.50.0...kani-0.51.0

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.

---------

Co-authored-by: Adrian Palacios <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The copyright check doesn't seem to be working

2 participants