RFC: Loop Contracts #3167
Merged
RFC: Loop Contracts #3167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
reviewed
Aug 2, 2024
feliperodri
requested changes
Aug 6, 2024
celinval
reviewed
Aug 19, 2024
Co-authored-by: Celina G. Val <[email protected]>
Contributor
Author
|
@celinval |
celinval
reviewed
Aug 29, 2024
Contributor
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
Thanks @qinheping! It's looking pretty good.
Co-authored-by: Celina G. Val <[email protected]>
feliperodri
approved these changes
Aug 30, 2024
Contributor
feliperodri
left a comment
feliperodri
left a comment
There was a problem hiding this comment.
Thank you for addressing all the comments. LGTM!
celinval
reviewed
Aug 30, 2024
Contributor
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
I only have one last question about feature opt-in / opt-out. Like contracts, I am not convinced that a user always wants the loop to be abstracted.
This was referenced Oct 9, 2024
This was referenced Nov 8, 2024
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC for loop contracts in Kani.
Rendered version available here.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.