Skip to content

Fix flaky tests #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
celinval merged 2 commits into from
Jun 21, 2023
Merged

Fix flaky tests #2553

celinval merged 2 commits into from
Jun 21, 2023

Conversation

@celinval
Copy link
Contributor

@celinval celinval commented Jun 21, 2023

Description of changes:

This PR fixes a few flaky tests that started to fail in the ongoing toolchain update (#2551)

  • The object bits test itself doesn't create that many objects since an array is represented as the same allocated object. Use LinkedList instead.
  • Do not rely on property number.
  • Do not rely on the order that failed checks is printed.

Resolved issues:

N/A

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested? N/A

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@celinval
Fix flaky tests
eb7035a 
 - The object bits test itself doesn't create that many objects since
   an array is represented as the same allocated object. Use LinkedList
   instead.
 - Do not rely on property number.
 - Do not rely on the order that failed checks is printed.
@celinval celinval requested a review from a team as a code owner June 21, 2023 21:50
jaisnan
jaisnan approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@celinval celinval enabled auto-merge (squash) June 21, 2023 22:38
@celinval celinval merged commit 43bc890 into model-checking:main Jun 21, 2023
@qinheping qinheping mentioned this pull request Jul 23, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhassan-aws zhassan-aws zhassan-aws approved these changes

+1 more reviewer

@jaisnan jaisnan jaisnan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@celinval @zhassan-aws @jaisnan