Enforce unstable APIs can only be used if the related feature is enabled #2386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpaco-aws
reviewed
Apr 19, 2023
zhassan-aws
reviewed
Apr 19, 2023
Co-authored-by: Zyad Hassan <[email protected]> Co-authored-by: Adrian Palacios <[email protected]>
zhassan-aws
approved these changes
Apr 27, 2023
Contributor
zhassan-aws
left a comment
zhassan-aws
left a comment
There was a problem hiding this comment.
LGTM. Adding a debug assert when the unstable annotation is not parseable would be nice, but not necessary in this PR.
Contributor
Author
I just added in the last revision. :) |
- Break down check attribute function - Improve comment - Add debug_assert for invalid unstable attribute - Make all fields required
celinval
force-pushed
the
issue-2279-unstable-api
branch
from
8ea47ab to
9189813
Compare
Co-authored-by: Adrian Palacios <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds the new opt-in option for users to enable unstable features (via
-Zoption orunstabletable in Cargo.toml). This PR also adds logic to parse and verify APIs tagged withunstable.Resolved issues:
Fixes #2357
Related RFC:
#2279
Call-outs:
Testing:
How is this change tested? New tests
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.