Upgrade toolchain to 2023-02-05 #2347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
toolchain-2023-02-05-manual
branch
2 times, most recently
from
f545852 to
ad0d9cb
Compare
celinval
reviewed
Apr 6, 2023
tautschnig
force-pushed
the
toolchain-2023-02-05-manual
branch
10 times, most recently
from
00b08f8 to
a43c5a8
Compare
celinval
reviewed
Apr 13, 2023
Contributor
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
Thanks for doing this @tautschnig!
This was referenced Apr 13, 2023
tautschnig
force-pushed
the
toolchain-2023-02-05-manual
branch
from
a43c5a8 to
0064927
Compare
3 tasks
tautschnig
force-pushed
the
toolchain-2023-02-05-manual
branch
from
0064927 to
e539fdc
Compare
celinval
reviewed
Apr 13, 2023
Contributor
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
I think we can still simplify the enum case. Here is an example using a temporary variable:
tautschnig
force-pushed
the
toolchain-2023-02-05-manual
branch
3 times, most recently
from
24ca8d2 to
b655505
Compare
4 tasks
tautschnig
force-pushed
the
toolchain-2023-02-05-manual
branch
from
b655505 to
c34d9a5
Compare
tautschnig
changed the title
celinval
reviewed
Apr 14, 2023
Contributor
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
It looks good! Thanks @tautschnig. I just have a few minor comments.
There will be future re-use of this code, so move it to a public function.
tautschnig
force-pushed
the
toolchain-2023-02-05-manual
branch
from
c34d9a5 to
7c62cf1
Compare
tautschnig
force-pushed
the
toolchain-2023-02-05-manual
branch
from
7c62cf1 to
a576aa4
Compare
Simplify the code by reusing some of the existing logic
tautschnig
force-pushed
the
toolchain-2023-02-05-manual
branch
from
a576aa4 to
80afe84
Compare
celinval
approved these changes
Apr 14, 2023
Contributor
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
Awesome!! Thanks again for the great work.
This was referenced Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Implement AggregateKind::{Adt,Closure,Generator} which are being used when moving toolchains from nightly 2023-02-04 to 2023-02-05 (or any later date).
Resolved issues:
Attempting to upgrade the toolchain to 2023-02-05.
Related RFC:
n/a
Call-outs:
n/a
Testing:
How is this change tested? All CI checks pass, which includes two additional tests.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.