Add tests for issues related to std linking #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, it looks like there are still issues with with how we are encoding panic threads and dynamic objects which are causing two of the test cases to fail. I'll document my findings in the original issue for each.
adpaco-aws
approved these changes
Oct 26, 2022
| @@ -0,0 +1,49 @@ | |||
| // Copyright Kani Contributors | |||
There was a problem hiding this comment.
Since this example comes from a book, shouldn't we use the copyright for modifications?
| } | ||
|
|
||
| #[kani::proof] | ||
| #[kani::unwind(10)] |
There was a problem hiding this comment.
Is this annotation needed?
There was a problem hiding this comment.
Let me double check. I think I just copied from the issue description.
| @@ -1,12 +1,13 @@ | |||
| // Copyright Kani Contributors | |||
| // SPDX-License-Identifier: Apache-2.0 OR MIT | |||
| // This test takes too long with all the std symbols. Use --legacy-linker for now. | |||
There was a problem hiding this comment.
This should be updated. Maybe you can remove and explain that original takes too long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add tests for #564, #208 and #87.
Resolved issues:
Resolves #564
Resolves #1620
Related RFC:
#1588
Call-outs:
Unfortunately, it looks like there are still issues with with how we are encoding panic threads and dynamic objects which are causing two of the test cases to fail.
I'll document my findings in the original issue for each.
Testing:
How is this change tested? New tests
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.