Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: cleanup javadoc for modularity #3386

Merged
merged 1 commit into from
Jun 28, 2024
Merged

docs: cleanup javadoc for modularity #3386

merged 1 commit into from
Jun 28, 2024

Conversation

xenoterracide
Copy link
Contributor

@xenoterracide xenoterracide commented Jun 28, 2024 •
edited
Loading

refs: #2604

also

  • skip checkstyle fixing module-info.java

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@xenoterracide xenoterracide force-pushed the docs/cleanup-for-jpms branch 3 times, most recently from ea692e3 to ea587a7 Compare June 28, 2024 14:11
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.36%. Comparing base (01da000) to head (29305a8).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #3386   +/-   ##
=========================================
  Coverage     85.36%   85.36%           
  Complexity     2927     2927           
=========================================
  Files           336      336           
  Lines          8908     8908           
  Branches       1110     1110           
=========================================
  Hits           7604     7604           
  Misses         1013     1013           
  Partials        291      291

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xenoterracide
docs: cleanup javadoc for modularity
29305a8 
refs: mockito#2604

also
- skip checkstyle checking module-info.java
@xenoterracide xenoterracide force-pushed the docs/cleanup-for-jpms branch from ea587a7 to 29305a8 Compare June 28, 2024 14:17
@xenoterracide
Copy link
Contributor Author

@TimvdLippe let me know if you want me to split this any further

@TimvdLippe TimvdLippe merged commit 29e0378 into mockito:main Jun 28, 2024
18 checks passed
@winterCloudz1706 winterCloudz1706 mentioned this pull request Sep 6, 2024
Closed
@TimvdLippe TimvdLippe mentioned this pull request Jan 2, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xenoterracide @codecov-commenter @TimvdLippe