Indent with spaces using spotless#1820
Merged
TimvdLippe merged 1 commit intorelease/3.xfrom Nov 7, 2019
Merged
Conversation
bric3
reviewed
Nov 7, 2019
Contributor
bric3
left a comment
bric3
left a comment
There was a problem hiding this comment.
Cool.
Actually while I think that fixing those is nice. I think spotless is not about well chained method (on the the dot).
bric3
approved these changes
Nov 7, 2019
Contributor
Author
|
Yes that is correct. I think at that point you need a formatter like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered in #1818 that (if new contributors are unaware of our indentation with 4 spaces), spotless did not fix the formatting.
indentWithSpaces(4)does just that and it actually found other formatting issues.