Skip to content

Typos and upcoming warnings#1795

Merged
TimvdLippe merged 1 commit intomockito:release/3.xfrom
DrTTom:release/3.x
Dec 7, 2019
Merged

Typos and upcoming warnings#1795
TimvdLippe merged 1 commit intomockito:release/3.xfrom
DrTTom:release/3.x

Conversation

@DrTTom
Copy link
Copy Markdown
Contributor

@DrTTom DrTTom commented Oct 2, 2019 •
edited
Loading

Fixed some typos which where found by a spell checker.

check list

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

TimvdLippe
TimvdLippe requested changes Oct 2, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split up your PR into multiple PRs that do one thing only? E.g. 1 PR to fix typos, 1 to fix errorprone warnings, etc..

Also please use descriptive commit messages and have a clear PR description.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 8, 2019 •
edited
Loading

Codecov Report

Merging #1795 into release/3.x will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             release/3.x   #1795   +/-   ##
=============================================
  Coverage           86.6%   86.6%           
  Complexity          2494    2494           
=============================================
  Files                310     310           
  Lines               6564    6564           
  Branches             821     821           
=============================================
  Hits                5685    5685           
  Misses               682     682           
  Partials             197     197
Impacted Files Coverage Δ Complexity Δ
...ternal/exceptions/stacktrace/StackTraceFilter.java 78.04% <ø> (ø) 8 <0> (ø) ⬇️
...ockito/internal/util/reflection/InstanceField.java 50% <ø> (ø) 9 <0> (ø) ⬇️
...roid/internal/creation/AndroidTempFileLocator.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ternal/util/reflection/GenericMetadataSupport.java 87.12% <0%> (ø) 38 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae17940...96830b9. Read the comment docs.

@TimvdLippe TimvdLippe merged commit 49c3b4f into mockito:release/3.x Dec 7, 2019
epeee pushed a commit to epeee/mockito that referenced this pull request Jun 22, 2020
@DrTTom @epeee
Fix several typos found by a spell checker (mockito#1795)
17b71cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimvdLippe TimvdLippe TimvdLippe requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DrTTom @codecov-io @TimvdLippe