Skip to content

Upgraded JUnit Jupiter 5.1.1 -> 5.4.2#1788

Merged
mockitoguy merged 1 commit intorelease/3.xfrom
parallel
Sep 28, 2019
Merged

Upgraded JUnit Jupiter 5.1.1 -> 5.4.2#1788
mockitoguy merged 1 commit intorelease/3.xfrom
parallel

Conversation

@mockitoguy
Copy link
Copy Markdown
Member

@mockitoguy mockitoguy commented Sep 28, 2019

We need higher version of JUnit Jupiter to reproduce and fix #1630

Added a test to enhance coverage

@mockitoguy
Bumped JUnit Jupiter and added a test
939ab5c 
Added a test to enhance coverage. We need higher version of JUnit Jupiter to reproduce and fix #1630
@mockitoguy mockitoguy changed the title Bumped JUnit Jupiter and added a test Bumped JUnit Jupiter Sep 28, 2019
@mockitoguy mockitoguy changed the title Bumped JUnit Jupiter Bumped JUnit Jupiter 5.1.1 -> 5.4.2 Sep 28, 2019
@mockitoguy mockitoguy changed the title Bumped JUnit Jupiter 5.1.1 -> 5.4.2 Upgraded JUnit Jupiter 5.1.1 -> 5.4.2 Sep 28, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 28, 2019 •
edited
Loading

Codecov Report

Merging #1788 into release/3.x will decrease coverage by 0.62%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/3.x    #1788      +/-   ##
=================================================
- Coverage          86.58%   85.96%   -0.63%     
+ Complexity          2491     2480      -11     
=================================================
  Files                310      310              
  Lines               6562     6562              
  Branches             822      822              
=================================================
- Hits                5682     5641      -41     
- Misses               682      723      +41     
  Partials             198      198
Impacted Files Coverage Δ Complexity Δ
...o/errorprone/bugpatterns/MockitoInternalUsage.java 0% <0%> (-100%) 0% <0%> (-6%)
...o/errorprone/bugpatterns/MockitoNotExtensible.java 0% <0%> (-100%) 0% <0%> (-4%)
...ternal/exceptions/stacktrace/StackTraceFilter.java 39.02% <0%> (-39.03%) 8% <0%> (ø)
...al/creation/bytebuddy/InlineBytecodeGenerator.java 83.8% <0%> (-4.23%) 27% <0%> (ø)
...ito/internal/creation/bytebuddy/ModuleHandler.java 23.07% <0%> (-3.85%) 2% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16328db...939ab5c. Read the comment docs.

@mockitoguy mockitoguy mentioned this pull request Sep 28, 2019
Closed
@mockitoguy
Copy link
Copy Markdown
Member Author

mockitoguy commented Sep 28, 2019

Coverage drop is a red herring. I verified the new test runs as part of CI. Merging!

@mockitoguy mockitoguy merged commit 1129199 into release/3.x Sep 28, 2019
@mockitoguy mockitoguy deleted the parallel branch September 28, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimvdLippe TimvdLippe TimvdLippe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mockito JUnit Jupiter extension does not correctly support parallel test execution

3 participants

@mockitoguy @codecov-io @TimvdLippe