Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll to bottom button hiding itself in the bottom #97

Merged
merged 4 commits into from
Jul 12, 2022
Merged

Scroll to bottom button hiding itself in the bottom #97

merged 4 commits into from
Jul 12, 2022

Conversation

voltangle
Copy link
Collaborator

No description provided.

@voltangle voltangle self-assigned this Jul 12, 2022
@voltangle voltangle added enhancement New feature or request OS: all Related to all operating systems (macOS and iPadOS) ux UX(User Experience) stuff labels Jul 12, 2022
@voltangle voltangle linked an issue Jul 12, 2022 that may be closed by this pull request
The "Scroll to bottom" button is still visible when at the bottom #79
Closed
@voltangle voltangle added bug Something isn't working and removed enhancement New feature or request labels Jul 12, 2022
@voltangle voltangle added this to the Stage 2: Media empire milestone Jul 12, 2022
@voltangle voltangle merged commit 83cb325 into master Jul 12, 2022
@voltangle voltangle deleted the scroll_to_bottom_fix branch July 12, 2022 20:11
dmikots pushed a commit that referenced this pull request Jul 13, 2022
@voltangle @dmikots
Scroll to bottom button hiding itself in the bottom (#97)
11accc1 
* feat: bumped Swift version in modules to 5.7

* feat: added a preference key to track scroll view position

* feat: implemented the scroll to bottom button hiding algorhitm

* fix: build on iPadOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@voltangle voltangle

Labels
bug Something isn't working OS: all Related to all operating systems (macOS and iPadOS) ux UX(User Experience) stuff
Projects
Moc
Status: Done
Milestone
Stage 2: Media empire
Development

Successfully merging this pull request may close these issues.

The "Scroll to bottom" button is still visible when at the bottom
1 participant
@voltangle