Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for Networking module #93

Merged
merged 3 commits into from
Jul 10, 2022
Merged

Tests for Networking module #93

merged 3 commits into from
Jul 10, 2022

Conversation

dmikots
Copy link
Contributor

@dmikots dmikots commented Jul 9, 2022

some problem with bundle

@dmikots dmikots added bug Something isn't working OS: all Related to all operating systems (macOS and iPadOS) labels Jul 9, 2022
@dmikots dmikots requested a review from voltangle July 9, 2022 11:25
@dmikots dmikots marked this pull request as draft July 9, 2022 11:27
voltangle
voltangle requested changes Jul 9, 2022
View reviewed changes
Networking/Sources/Networking/Services/Emoji/EmojiModel.swift
struct Result: Codable {
let id: Int
let name, emoji, unicode: String
let category, subCategory: Category
Copy link
Collaborator

@voltangle voltangle Jul 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo subcategory will better suit as a name

Networking/Sources/Networking/Services/Emoji/EmojiModel.swift

enum CodingKeys: String, CodingKey {
case id, name, emoji, unicode, category
case subCategory = "sub_category"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@voltangle voltangle added enhancement New feature or request internal Internal things and removed bug Something isn't working labels Jul 9, 2022
@voltangle voltangle added this to the Stage 2: Media empire milestone Jul 9, 2022
@voltangle voltangle linked an issue Jul 9, 2022 that may be closed by this pull request
add Moc tests for Networking #90
Closed
@voltangle voltangle mentioned this pull request Jul 9, 2022
Open
@dmikots dmikots marked this pull request as ready for review July 10, 2022 09:54
@dmikots dmikots requested a review from voltangle July 10, 2022 09:54
@voltangle voltangle changed the title add test. Problem with package bundle Tests for Networking module Jul 10, 2022
@voltangle voltangle merged commit db93bf5 into master Jul 10, 2022
@voltangle voltangle deleted the networking_tests branch July 11, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voltangle voltangle voltangle approved these changes

Assignees

@dmikots dmikots

Labels
enhancement New feature or request internal Internal things OS: all Related to all operating systems (macOS and iPadOS)
Projects
Moc
Status: Done
Milestone
Stage 2: Media empire
Development

Successfully merging this pull request may close these issues.

add Moc tests for Networking
2 participants
@dmikots @voltangle