Drastic refactor + message formatting #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voltangle
added
enhancement
Closed
* feat: first work in completely redesigning the service system * feat: that's a large one - Fully rewritten ChatService API - Made TdApi shared property not an array - General refactors * refactor: done TdMainService refactor also touched slightly the Caching module * refactor: LoginService done * fix: removed unused TODO * feat: reimplemented a part of the code in update(chat:) in ChatViewModel, but still left some things to do * fix: added db migration to fix crash on startup with old databases * refactor: AccountsPrefService
aaaaaand i don't like the result, i will revert the move and just tweak ChatSplitView slightly
and also did there bold, italic, and links
voltangle
changed the title
now it properly searches for a size instead of just guessing with a fucking array index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short
This PR does a lot of work under the hood, which aims to make the codebase more maintainable and easier to interact with, like reorganizing views, splitting large views into smaller ones, rewriting some old parts of the code that were written a long ago, when I was at the start of my journey into Swift and Apple development at large
Task list