Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on Moc's session being remotely terminated #98

Closed
voltangle opened this issue Jul 12, 2022 · 1 comment · Fixed by #102
Closed

Crash on Moc's session being remotely terminated #98

voltangle opened this issue Jul 12, 2022 · 1 comment · Fixed by #102
Assignees
@voltangle
Labels
bug Something isn't working internal Internal things OS: all Related to all operating systems (macOS and iPadOS)
Milestone
Stage 2: Media em...

Comments

@voltangle
Copy link
Collaborator

When Moc is running, and its session was terminated by another device, it just outright crashes

Reason

The reason is the handling of AuthorizationState.closed state and the reinstantiation of the TDLib instance, which, as we see, fails miserably.
@voltangle voltangle added bug Something isn't working OS: all Related to all operating systems (macOS and iPadOS) internal Internal things labels Jul 12, 2022
@voltangle voltangle added this to the Stage 2: Media empire milestone Jul 12, 2022
@voltangle voltangle self-assigned this Jul 12, 2022
@voltangle voltangle added this to Moc Jul 12, 2022
@voltangle
Copy link
Collaborator Author

After a bit of research, it turns out that it actually crashes when starting it up after the session was ended when Moc was closed

@voltangle voltangle linked a pull request Jul 14, 2022 that will close this issue
Fix session termination crash #102
Merged
@voltangle voltangle moved this to In Progress in Moc Jul 15, 2022
Repository owner moved this from In Progress to Done in Moc Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@voltangle voltangle

Labels
bug Something isn't working internal Internal things OS: all Related to all operating systems (macOS and iPadOS)
Projects
Moc
Status: Done
Milestone
Stage 2: Media empire
Development

Successfully merging a pull request may close this issue.

Fix session termination crash mock-foundation/moc
1 participant
@voltangle