Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on viewing certain album messages #128

Closed
voltangle opened this issue Aug 9, 2022 · 7 comments · Fixed by #147
Closed

Crash on viewing certain album messages #128

voltangle opened this issue Aug 9, 2022 · 7 comments · Fixed by #147
Assignees
@voltangle
Labels
bug Something isn't working critical This issue/pull request should be done as fast as possible internal Internal things OS: all Related to all operating systems (macOS and iPadOS)

Comments

@voltangle
Copy link
Collaborator

voltangle commented Aug 9, 2022 •
edited
Loading

...and I currently have no idea which exact messages provoke this kind of behavior. For now we have the crash reports from AppCenter, which help us understand that the issue is in media messages, specifically photos and/or videos.

Here are crashes themselves:
First
Second

I should investigate what exact messages were the culprits of these crashes, and hopefully fix them.
@voltangle voltangle added bug Something isn't working OS: all Related to all operating systems (macOS and iPadOS) internal Internal things critical This issue/pull request should be done as fast as possible labels Aug 9, 2022
@voltangle voltangle added this to the Stage 2: Media empire milestone Aug 9, 2022
@voltangle voltangle self-assigned this Aug 9, 2022
@voltangle voltangle added this to Moc Aug 9, 2022
@voltangle voltangle moved this to Todo in Moc Aug 9, 2022
@voltangle
Copy link
Collaborator Author

I have found where to reproduce the crash, trying to narrow down the cause

@voltangle
Copy link
Collaborator Author

Bruh, this is actually makeDocument inside of makeAlbum
how the fuck a document message is inside of an album watafuk

@voltangle
Copy link
Collaborator Author

After more investigation, I'm sure that photo and video rendering is working as it should, only the document one is broken

@voltangle voltangle moved this from Todo to In Progress in Moc Aug 11, 2022
@voltangle
Copy link
Collaborator Author

Oh wow, not only the document one causes crashes

@voltangle
Copy link
Collaborator Author

Closing due to issue not being related to my bad code but rather to a bug in SwiftUI, because this issue is not a thing in Ventura

@voltangle voltangle closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2022
Repository owner moved this from In Progress to Done in Moc Aug 19, 2022
@voltangle
Copy link
Collaborator Author

ARE YOU FUCKING KIDDING ME I TRIGGERED THIS CRASH ON VENTURA HOW

@voltangle voltangle reopened this Aug 20, 2022
@voltangle voltangle changed the title Moc crashes on certain messages Moc crashes on certain album messages Aug 20, 2022
@voltangle voltangle mentioned this issue Aug 20, 2022
Closed
@voltangle voltangle removed this from Moc Aug 21, 2022
@voltangle voltangle added this to Moc Aug 21, 2022
@voltangle voltangle moved this to Backlog in Moc Aug 21, 2022
@voltangle voltangle removed this from the Stage 2: Media empire milestone Aug 21, 2022
@voltangle voltangle changed the title Moc crashes on certain album messages Crash on viewing certain album messages Aug 21, 2022
@voltangle
Copy link
Collaborator Author

New info found: with Adress Sanitizer enabled in Xcode I was able to find an understandable error name for hoomans: it's a stack overflow
how the fuck does it happen? I have no idea! But, well, we have nothing else to do than to investigate more

@levochkaa levochkaa mentioned this issue Sep 13, 2022
Merged
@voltangle voltangle linked a pull request Sep 13, 2022 that will close this issue
fix: crash on viewing albums #147
Merged
Repository owner moved this from Backlog to Done in Moc Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@voltangle voltangle

Labels
bug Something isn't working critical This issue/pull request should be done as fast as possible internal Internal things OS: all Related to all operating systems (macOS and iPadOS)
Projects
Moc
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: crash on viewing albums
1 participant
@voltangle