Repository navigation
Conversation
Each worker applied --fail-zero to its own file, so every file where --grep matched nothing added one failure to the exit code. Stop sending failZero to workers and check the test count reported by all workers once, at the end of the run. Closes mochajs#4969
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
With
--parallel, each worker got thefailZerooption and applied it to its own file. Every file where--grepmatched nothing reported one failure, and the main process added those up, so the exit code was the number of such files even when the matching tests passed.Workers no longer get
failZero. Instead, the parallel runner counts the tests the workers report and fails the run at the end if there were none. It only does this when nothing else has failed, so a run where failingbeforehooks skipped every test keeps the same exit code as in serial mode.Added integration tests for
--grepmatching tests in only some files (exit 0) and in none (exit 1, same as serial), plus unit tests for the runner.