Expose MountedByOpenat2 as a public function so that k8s can consume#96
Closed
manugupt1 wants to merge 1 commit intomoby:masterfrom
Closed
Expose MountedByOpenat2 as a public function so that k8s can consume#96manugupt1 wants to merge 1 commit intomoby:masterfrom
manugupt1 wants to merge 1 commit intomoby:masterfrom
Conversation
…nsumers can consume it Signed-off-by: Manu Gupta <[email protected]>
Collaborator
|
I think it's better to export something like 'MountedFast' which includes all the methods except for parsing mountinfo. I'll create the PR. |
Collaborator
OK, this is problematic, because there's no way to communicate back to the caller if we're sure this is not a mount point. Unless we do something like this: func MountedFast(path string) (mounted, sure bool, err error)when |
Contributor
Author
That is something that will work to; my PR always falls back if the fast path cannot guarantee a mount-point. |
manugupt1
pushed a commit
to manugupt1/sys
that referenced
this pull request
Dec 8, 2021
MountedFast is a method of detecting mount points really fast. It works for all kinds of mounts (incl. bind mounts) but requires a recent (v5.6+) Linux kernel. A mount-point check is guaranteed to be a mount-point or not only when sure is true. When sure is false, the caller needs to check for other methods (eg: parse /proc/mounts) to successfully determine if it is a mount-point. This has been motivated by kubernetes/kubernetes#105833 (comment) and moby#96 (comment)
manugupt1
pushed a commit
to manugupt1/sys
that referenced
this pull request
Dec 8, 2021
MountedFast is a method of detecting mount points really fast. It works for all kinds of mounts (incl. bind mounts) but requires a recent (v5.6+) Linux kernel. A mount-point check is guaranteed to be a mount-point or not only when sure is true. When sure is false, the caller needs to check for other methods (eg: parse /proc/mounts) to successfully determine if it is a mount-point. This has been motivated by kubernetes/kubernetes#105833 (comment) and moby#96 (comment)
manugupt1
pushed a commit
to manugupt1/sys
that referenced
this pull request
Dec 8, 2021
MountedFast is a method of detecting mount points really fast. It works for all kinds of mounts (incl. bind mounts) but requires a recent (v5.6+) Linux kernel. A mount-point check is guaranteed to be a mount-point or not only when sure is true. When sure is false, the caller needs to check for other methods (eg: parse /proc/mounts) to successfully determine if it is a mount-point. This has been motivated by kubernetes/kubernetes#105833 (comment) and moby#96 (comment)
manugupt1
pushed a commit
to manugupt1/sys
that referenced
this pull request
Dec 8, 2021
MountedFast is a method of detecting mount points really fast. It works for all kinds of mounts (incl. bind mounts) but requires a recent (v5.6+) Linux kernel. A mount-point check is guaranteed to be a mount-point or not only when sure is true. When sure is false, the caller needs to check for other methods (eg: parse /proc/mounts) to successfully determine if it is a mount-point. This has been motivated by kubernetes/kubernetes#105833 (comment) and moby#96 (comment) Signed-off-by: Manu Gupta <[email protected]>
Contributor
Author
|
Closing in favor of #97 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose MountedByOpenat2 as a public function so that k8s can consume
One of the alternatives suggested here is to expose MountedByOpenat2 as a public function
so that k8s can consume and rest of the downstream can also benefit from it.
kubernetes/kubernetes#105833 (comment)
cc @kolyshkin