Skip to content

Drop go < 1.16 compatibility#89

Merged
thaJeztah merged 4 commits intomoby:masterfrom
kolyshkin:go116-min
Oct 28, 2021
Merged

Drop go < 1.16 compatibility#89
thaJeztah merged 4 commits intomoby:masterfrom
kolyshkin:go116-min

Conversation

@kolyshkin
Copy link
Copy Markdown
Collaborator

Go 1.15 is not supported since Go 1.17 release in August 2021.

This is mostly so we can use new functionality, such as (*testing.T).TestDir,
as well as replacements for ioutil functions.

NOTE we do not have to replace all ioutil uses yet, as it is still not deprecated.
This is just to open a way to use whatever is available in Go 1.16.

Also, some go-1.16 and go-1.17 related cleanups.

Go 1.15 is not supported since Go 1.17 release in August 2021.

This is mostly so we can use replacements for ioutil functions
(note that we do not have to replace all ioutil uses for now, as
it is still not deprecated), as well as testing.TestDir and such.

Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
This is mostly to have the same x/sys/unix version in all modules.

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin kolyshkin requested a review from thaJeztah October 27, 2021 20:46
Copy link
Copy Markdown
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 1bcc0b1 into moby:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants