Skip to content

ci: add go1.24, add macOS 15, remove ubuntu 20.04 (EOL) and update golangci-lint to v2.0.2#186

Merged
thaJeztah merged 4 commits intomoby:mainfrom
thaJeztah:bump_gha
Apr 7, 2025
Merged

ci: add go1.24, add macOS 15, remove ubuntu 20.04 (EOL) and update golangci-lint to v2.0.2#186
thaJeztah merged 4 commits intomoby:mainfrom
thaJeztah:bump_gha

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Apr 4, 2025 •
edited
Loading

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Apr 4, 2025 •
edited
Loading

Ah, derp;

Error: atomicwriter/atomicwriter.go:205:11: QF1008: could remove embedded field "File" from selector (staticcheck)
	err := w.File.Sync()
	         ^

Error: mountinfo/mounted_linux_test.go:282:6: QF1001: could apply De Morgan's law (staticcheck)
		if !(tc.isNotExist && errors.Is(err, os.ErrNotExist)) {
		   ^
Error: mountinfo/mounted_linux_test.go:353:8: QF1001: could apply De Morgan's law (staticcheck)
				if !(tc.isNotExist && errors.Is(err, os.ErrNotExist)) {
				   ^

Error: capability/syscall_linux.go:144:2: QF1003: could use tagged switch on data.version (staticcheck)
	if data.version == 1 {
	^

@thaJeztah thaJeztah mentioned this pull request Apr 4, 2025
Merged
@thaJeztah thaJeztah marked this pull request as draft April 4, 2025 21:40
@thaJeztah thaJeztah force-pushed the bump_gha branch 3 times, most recently from b35a46d to ca727c3 Compare April 7, 2025 12:33
thaJeztah added 4 commits April 7, 2025 14:42
@thaJeztah
ci: add go1.24, remove go1.22
c3dfbf5 
We test against "oldest supported", "latest" and "latest -1"

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
ci: add macos-15
1b366ac 
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
ci: remove ubuntu-20.04 (EOL)
6fe149d 
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
ci: update golangci-lint to v2.0.2
6daecd6 
Update to the latest version, and migrate the config (using the
migrate command). Also tweak the config for staticcheck; enabling
all options, but disabling 2.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah marked this pull request as ready for review April 7, 2025 12:43
@thaJeztah thaJeztah closed this Apr 7, 2025
@thaJeztah thaJeztah reopened this Apr 7, 2025
@thaJeztah thaJeztah closed this Apr 7, 2025
@thaJeztah thaJeztah reopened this Apr 7, 2025
@thaJeztah thaJeztah merged commit 4a75548 into moby:main Apr 7, 2025
58 checks passed
@thaJeztah thaJeztah deleted the bump_gha branch April 7, 2025 15:07
kolyshkin
kolyshkin reviewed Apr 7, 2025
View reviewed changes
Comment thread .github/workflows/test.yml Outdated
@kolyshkin kolyshkin mentioned this pull request Apr 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolyshkin kolyshkin kolyshkin left review comments

@vvoland vvoland vvoland approved these changes

@robmry robmry robmry approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @kolyshkin @vvoland @robmry