Merged
Conversation
- Fix references to EvalSymlinksInScope, which is non-exported - Add relevant links to original implementation / introduction of the code to allow comparing the fork with the original upstream code. - Move GoDoc from the non-exported evalSymlinksInScope function to the exported FollowSymlinkInScope. - Remove the README.md, instead using doc.go to provide the package description. Signed-off-by: Sebastiaan van Stijn <[email protected]>
kolyshkin
reviewed
Jul 9, 2024
Comment on lines
+6
to
+7
| // Read the [LICENSE.BSD] file that governs fs.go and [LICENSE.APACHE] for | ||
| // fs_unix_test.go. |
Collaborator
There was a problem hiding this comment.
Can/should we add references to the files we're talking about (i.e. fs.go -> [fs.go])?
Member
Author
There was a problem hiding this comment.
I was considering that initially, but didn't know what the most suitable link for that would be (linking to main could cause the link to break potentially, and linking to a versioned one could be confusing when linking from version X to version "old"), so I "somewhat" kept that an exercise to the user for now.
Member
Author
|
I'll bring this one in; will also have a look at possibly doing some patch releases with our latest changes (but need to check how important they are). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
symlink: touch-up documentation
Before:
After: