Conversation
kolyshkin
changed the title
kolyshkin
force-pushed
the
bump-ci
branch
2 times, most recently
from
5a708b5 to
ba81eaa
Compare
|
@thaJeztah ptal |
| require ( | ||
| github.com/moby/sys/mountinfo v0.6.2 | ||
| golang.org/x/sys v0.0.0-20220520151302-bc2c85ada10a | ||
| golang.org/x/sys v0.11.0 |
There was a problem hiding this comment.
if we don't need anything newer, I prefer follow Go module's "minimum version selection", and use the oldest tagged version (v0.1.0), and leave it up to users of this module to pick the version they want
|
@kolyshkin are you ok with picking a "minimum" version for golang.org/x/sys, or did you have a specific reason to require the latest version? |
Yes, I don't think we have a requirement for a specific version here. Will update. |
Since Go 1.20,
> [t]he fmt.Errorf function now supports multiple occurrences of the %w
> format verb, which will cause it to return an error that wraps all of
> those error operands.
This change, together with newer errorlint, causes the following
warning:
> mount_unix.go:74:56: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
> return fmt.Errorf("%w (possible cause: %s)", err, suberr)
> ^
As we still want to support Go 1.17, use explicit string for suberr,
and add a TODO to switch to %w once we switch to Go 1.20+.
Fixes: 487129d
Signed-off-by: Kir Kolyshkin <[email protected]>
1. Test with supported Go releases (1.20.x and 1.21.x). Also leave Go 1.17.x since it costs us little to keep supporting it. 2. Bump golangci-lint to the latest released version (v1.55.1). 3. Bump actions/setup-go to v4. Signed-off-by: Kir Kolyshkin <[email protected]>
It is already that way for sequential, and Go 1.17 is the oldest version we use in CI, so let's bring other modules go.mod in sync. Signed-off-by: Kir Kolyshkin <[email protected]>
This is the oldest tagged version of x/sys. This allows to follow Go module's "minimum version selection", leaving it up to users of this module to pick the version they want. Signed-off-by: Kir Kolyshkin <[email protected]>
golangci-lint v1.54.2 comes with errorlint v1.4.4, which contains the fix [1] whitelisting all errno comparisons for errors coming from x/sys/unix. Remove the annotation that is no longer needed. Unfortunately, switch on a bare unix error (in mountinfo) still needs to be annotated (see [2]). [1] polyfloyd/go-errorlint#47 [2] polyfloyd/go-errorlint#54 Signed-off-by: Kir Kolyshkin <[email protected]>
This fixes the following CI error: > sequential_windows.go:114: File is not `gofumpt`-ed (gofumpt) Signed-off-by: Kir Kolyshkin <[email protected]>
|
@thaJeztah ptal |
1 similar comment
|
@thaJeztah ptal |
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM! Sorry for the delay, somehow this dropped off my radar 🙈
|
Looks like polyfloyd/go-errorlint@c0e6cac is part of go-errorlint v1.5.2, which is included in GolangCI-lint v1.59.1; https://github.com/golangci/golangci-lint/releases/tag/v1.59.1 I'll do a follow-up after this to update golangci-lint and to remove that other nolint-comment; also macos-12 runners were deprecated, so will include updates for that as well. |
2 participants
v0.11.0.v.0.1.0.