Skip to content

mount: fix unused/deadcode warnings on Mac#101

Merged
thaJeztah merged 1 commit intomoby:masterfrom
kolyshkin:darwin-deadcode
Jan 18, 2022
Merged

mount: fix unused/deadcode warnings on Mac#101
thaJeztah merged 1 commit intomoby:masterfrom
kolyshkin:darwin-deadcode

Conversation

@kolyshkin
Copy link
Copy Markdown
Collaborator

Since commit 7a52162 Mount is not implemented on Darwin, so
mount() is left unused.

Also, mount errors are only used from mount(), and thus are not used on
Darwin.

This fixes a bunch of warnings from "unused" and "deadcode" lints.

Alas, those warnings did not result in CI failures on Mac; see #99

Since commit 7a52162 Mount is not implemented on Darwin, so
mount() is left unused.

Also, mount errors are only used from mount(), and thus are not used on
Darwin.

This fixes a bunch of warnings from "unused" and "deadcode" lints.

Signed-off-by: Kir Kolyshkin <[email protected]>
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit 0ef20af into moby:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants